runtime/vm/intermediate_language.cc - Issue 11230034: Fix super ==: Test first for null before call inf super ==.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 11230034: Fix super ==: Test first for null before call inf super ==. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.cc

===================================================================

--- runtime/vm/intermediate_language.cc (revision 13897)

+++ runtime/vm/intermediate_language.cc (working copy)

@@ -1852,12 +1852,18 @@

void StaticCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

+ Label skip_call;

+ const String& equality_name = String::Handle(Symbols::New("=="));

hausner 2012/10/22 20:00:29 Ditto regarding using a symbol.

+ if (function().name() == equality_name.raw()) {

+ compiler->EmitSuperEqualityCallPrologue(locs()->out().reg(), &skip_call);

+ }

compiler->GenerateStaticCall(deopt_id(),

token_pos(),

function(),

ArgumentCount(),

argument_names(),

locs());

+ __ Bind(&skip_call);

}

« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/object.h » ('j') | runtime/vm/object.cc » ('J')