Fix super ==: Test first for null before call inf super ==.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
@@ skipping 3343 matching lines @@
 
 void Function::set_is_native(bool value) const {
   set_kind_tag(NativeBit::update(value, raw_ptr()->kind_tag_));
 }
 
 
 void Function::set_is_abstract(bool value) const {
   set_kind_tag(AbstractBit::update(value, raw_ptr()->kind_tag_));
 }
 
+
 void Function::set_is_inlinable(bool value) const {
   set_kind_tag(InlinableBit::update(value, raw_ptr()->kind_tag_));
 }
 
+
+bool Function::IsInlineable() const {
+  // '==' call is handled specially.
+  const String& equality_name = String::Handle(Symbols::New("=="));

[hausner, 2012/10/22 20:00:29]

I expect this will be called quite often. It might be beneficial to allocate the
string "==" in the symbol table instead of creating a new one each time (and
then throwing it away during canonicalization).

[srdjan, 2012/10/22 20:30:51]

Symbols::New does not create new symbol each time, but returns one if it already
exists in the symbol table.

+  return InlinableBit::decode(raw_ptr()->kind_tag_) &&
+         HasCode() &&
+         name() != equality_name.raw();
+}
+
+
 intptr_t Function::NumParameters() const {
   return num_fixed_parameters() + NumOptionalParameters();
 }
 
 
 intptr_t Function::NumImplicitParameters() const {
   if (kind() == RawFunction::kConstructor) {
     if (is_static()) {
       ASSERT(IsFactory());
       return 1;  // Type arguments.
@@ skipping 8827 matching lines @@
   }
   return result.raw();
 }
 
 
 const char* WeakProperty::ToCString() const {
   return "_WeakProperty";
 }
 
 }  // namespace dart