Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: runtime/vm/object.cc

Issue 11230034: Fix super ==: Test first for null before call inf super ==. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 13897)
+++ runtime/vm/object.cc (working copy)
@@ -3361,10 +3361,21 @@
set_kind_tag(AbstractBit::update(value, raw_ptr()->kind_tag_));
}
+
void Function::set_is_inlinable(bool value) const {
set_kind_tag(InlinableBit::update(value, raw_ptr()->kind_tag_));
}
+
+bool Function::IsInlineable() const {
+ // '==' call is handled specially.
+ const String& equality_name = String::Handle(Symbols::New("=="));
hausner 2012/10/22 20:00:29 I expect this will be called quite often. It might
srdjan 2012/10/22 20:30:51 Symbols::New does not create new symbol each time,
+ return InlinableBit::decode(raw_ptr()->kind_tag_) &&
+ HasCode() &&
+ name() != equality_name.raw();
+}
+
+
intptr_t Function::NumParameters() const {
return num_fixed_parameters() + NumOptionalParameters();
}

Powered by Google App Engine
This is Rietveld 408576698