Fix JS minifier to lift var declarations within functions. Still disabled.

Fix JS minifier to lift var declarations within functions.  Still disabled.
R=kasperl@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=13654

[floitsch, 2012-10-15 11:17:18]

LGTM.

https://codereview.chromium.org/11146013/diff/17/lib/compiler/implementation/...
File lib/compiler/implementation/js/printer.dart (right):

https://codereview.chromium.org/11146013/diff/17/lib/compiler/implementation/...
lib/compiler/implementation/js/printer.dart:799: void functionOut(Fun fun) {
"out" doesn't seem to fit. Maybe "collectVarsInFunction"?

https://codereview.chromium.org/11146013/diff/17/lib/compiler/implementation/...
lib/compiler/implementation/js/printer.dart:820:
functionOut(declaration.function);
Add comment that we are skipping the function-declaration's name.

https://codereview.chromium.org/11146013/diff/17/lib/compiler/implementation/...
lib/compiler/implementation/js/printer.dart:823: void
visitNamedFunction(NamedFunction namedFunction) {
Add comment that we are skipping the named-function's name.

https://codereview.chromium.org/11146013/diff/17/tests/compiler/dart2js/type_...
File tests/compiler/dart2js/type_inference2_test.dart (right):

https://codereview.chromium.org/11146013/diff/17/tests/compiler/dart2js/type_...
tests/compiler/dart2js/type_inference2_test.dart:16:
compileAndMatchFuzzy(TEST_ONE, 'sum', "\\+\\+x");
use raw string.

https://codereview.chromium.org/11146013/diff/17/tests/compiler/dart2js/type_...
File tests/compiler/dart2js/type_inference4_test.dart (right):

https://codereview.chromium.org/11146013/diff/17/tests/compiler/dart2js/type_...
tests/compiler/dart2js/type_inference4_test.dart:25: RegExp regexp = new
RegExp(getIntTypeCheck('[aj]'));
rename the array in the original code, so "a" won't mean the array.

https://codereview.chromium.org/11146013/diff/17/tests/compiler/dart2js/type_...
File tests/compiler/dart2js/type_inference5_test.dart (right):

https://codereview.chromium.org/11146013/diff/17/tests/compiler/dart2js/type_...
tests/compiler/dart2js/type_inference5_test.dart:24: RegExp regexp = new
RegExp(getIntTypeCheck('[aj]'));
rename "a" above so that the array cannot be confused with the int.
An even better way would be to get the name of the argument out of the generated
code. Something like
var arg = const RegExp(r"function\((arg)\)").firstMatch("generated")[0];

[ngeoffray, 2012-10-15 14:20:01]

https://codereview.chromium.org/11146013/diff/17/tests/compiler/dart2js/class...
File tests/compiler/dart2js/class_codegen_test.dart (right):

https://codereview.chromium.org/11146013/diff/17/tests/compiler/dart2js/class...
tests/compiler/dart2js/class_codegen_test.dart:57: A(a) : this.a = a {}
Why this change? (and the ones in the other tests?) I believe we still want to
have a nice pretty printer that keeps variable names, and it feels easier for
the tests to use that one instead of a minifier.