Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: tests/compiler/dart2js/class_codegen_test.dart

Issue 11146013: Fix JS minifier to lift var declarations within functions. Still disabled. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // Test that parameters keep their names in the output. 4 // Test that parameters keep their names in the output.
5 5
6 #import("compiler_helper.dart"); 6 #import("compiler_helper.dart");
7 #import("parser_helper.dart"); 7 #import("parser_helper.dart");
8 8
9 const String TEST_ONE = r""" 9 const String TEST_ONE = r"""
10 class A { } 10 class A { }
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 var z; 46 var z;
47 } 47 }
48 48
49 main() { 49 main() {
50 new B(); 50 new B();
51 } 51 }
52 """; 52 """;
53 53
54 const String TEST_FIVE = r""" 54 const String TEST_FIVE = r"""
55 class A { 55 class A {
56 var x; 56 var a;
57 A(x) : this.x = x {} 57 A(a) : this.a = a {}
ngeoffray 2012/10/15 14:20:01 Why this change? (and the ones in the other tests?
58 } 58 }
59 59
60 main() { 60 main() {
61 new A(3); 61 new A(3);
62 } 62 }
63 """; 63 """;
64 64
65 twoClasses() { 65 twoClasses() {
66 String generated = compileAll(TEST_ONE); 66 String generated = compileAll(TEST_ONE);
67 Expect.isTrue(generated.contains('\$.A = {"":\n [],\n "super": "Object"')); 67 Expect.isTrue(generated.contains('\$.A = {"":\n [],\n "super": "Object"'));
(...skipping 15 matching lines...) Expand all
83 print(generated); 83 print(generated);
84 Expect.isTrue(generated.contains(r""" 84 Expect.isTrue(generated.contains(r"""
85 $.B = {"": 85 $.B = {"":
86 ["y", "z", "x"], 86 ["y", "z", "x"],
87 "super": "A" 87 "super": "A"
88 }""")); 88 }"""));
89 } 89 }
90 90
91 constructor1() { 91 constructor1() {
92 String generated = compileAll(TEST_FIVE); 92 String generated = compileAll(TEST_FIVE);
93 Expect.isTrue(generated.contains(r"new $.A(x);")); 93 Expect.isTrue(generated.contains(r"new $.A(a);"));
94 } 94 }
95 95
96 main() { 96 main() {
97 twoClasses(); 97 twoClasses();
98 subClass(); 98 subClass();
99 fieldTest(); 99 fieldTest();
100 constructor1(); 100 constructor1();
101 } 101 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698