Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: tests/compiler/dart2js/type_guard_unuser_test.dart

Issue 11146013: Fix JS minifier to lift var declarations within functions. Still disabled. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/type_guard_unuser_test.dart
diff --git a/tests/compiler/dart2js/type_guard_unuser_test.dart b/tests/compiler/dart2js/type_guard_unuser_test.dart
index 367b62b2b781c6a8c4e6fa62264f5bc105ebbada..e9cdced0d49a02e2821eac5e1aae4a8a34e9a2de 100644
--- a/tests/compiler/dart2js/type_guard_unuser_test.dart
+++ b/tests/compiler/dart2js/type_guard_unuser_test.dart
@@ -6,9 +6,9 @@
const String TEST_ONE = r"""
foo(a) {
- int c = foo(true);
- if (a) c = foo(2);
- return c;
+ int b = foo(true);
+ if (a) b = foo(2);
+ return b;
}
""";
@@ -24,16 +24,16 @@ foo(d) {
""";
const String TEST_THREE = r"""
-foo(int param1, int param2) {
- return 0 + param1 + param2;
+foo(int a, int b) {
+ return 0 + a + b;
}
""";
const String TEST_THREE_WITH_BAILOUT = r"""
-foo(int param1, int param2) {
+foo(int a, int b) {
var t;
for (int i = 0; i < 1; i++) {
- t = 0 + param1 + param2;
+ t = 0 + a + b;
}
return t;
}
@@ -44,7 +44,7 @@ main() {
RegExp regexp = new RegExp(getIntTypeCheck(anyIdentifier));
Iterator<Match> matches = regexp.allMatches(generated).iterator();
checkNumberOfMatches(matches, 0);
- Expect.isTrue(generated.contains(r'return a === true ? $.foo(2) : c;'));
+ Expect.isTrue(generated.contains(r'return a === true ? $.foo(2) : b;'));
generated = compile(TEST_TWO, 'foo');
regexp = const RegExp("foo\\(1\\)");
@@ -52,14 +52,14 @@ main() {
checkNumberOfMatches(matches, 1);
generated = compile(TEST_THREE, 'foo');
- regexp = new RegExp(getNumberTypeCheck('param1'));
+ regexp = new RegExp(getNumberTypeCheck('a'));
Expect.isTrue(regexp.hasMatch(generated));
- regexp = new RegExp(getNumberTypeCheck('param2'));
+ regexp = new RegExp(getNumberTypeCheck('b'));
Expect.isTrue(regexp.hasMatch(generated));
generated = compile(TEST_THREE_WITH_BAILOUT, 'foo');
- regexp = new RegExp(getNumberTypeCheck('param1'));
+ regexp = new RegExp(getNumberTypeCheck('a'));
Expect.isTrue(regexp.hasMatch(generated));
- regexp = new RegExp(getNumberTypeCheck('param2'));
+ regexp = new RegExp(getNumberTypeCheck('b'));
Expect.isTrue(regexp.hasMatch(generated));
}

Powered by Google App Engine
This is Rietveld 408576698