tests/compiler/dart2js/class_codegen_test.dart - Issue 11146013: Fix JS minifier to lift var declarations within functions. Still disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/class_codegen_test.dart

Issue 11146013: Fix JS minifier to lift var declarations within functions. Still disabled. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/compiler/implementation/js/printer.dart ('K') | « lib/compiler/implementation/js/printer.dart ('k') | tests/compiler/dart2js/code_motion_test.dart » ('j') | tests/compiler/dart2js/type_inference2_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/class_codegen_test.dart

diff --git a/tests/compiler/dart2js/class_codegen_test.dart b/tests/compiler/dart2js/class_codegen_test.dart

index 09c45eb6de58c71ea993ce2f61c816baf410f10c..dae160e698a0a8cfa753a0014d0a259356c86f94 100644

--- a/tests/compiler/dart2js/class_codegen_test.dart

+++ b/tests/compiler/dart2js/class_codegen_test.dart

@@ -53,8 +53,8 @@ main() {

const String TEST_FIVE = r"""

class A {

- var x;

- A(x) : this.x = x {}

+ var a;

+ A(a) : this.a = a {}

ngeoffray 2012/10/15 14:20:01 Why this change? (and the ones in the other tests?

}

main() {

@@ -90,7 +90,7 @@ $.B = {"":

constructor1() {

String generated = compileAll(TEST_FIVE);

- Expect.isTrue(generated.contains(r"new $.A(x);"));

+ Expect.isTrue(generated.contains(r"new $.A(a);"));

}

main() {