Add crash dumps to service protocol and Observatory

Add crash dumps to service protocol and Observatory

- Add _getCrashDump RPC
- crash dump service response is map of request uris to responses, includes:
  -- getVM
  -- getFlagList
  -- for each isolate:
      -- getIsolate
      -- _getAllocationProfile
      -- getStack
- Add FakeVM to service library
- Add load crash dump to Observatory connect page
- Removes old chromium target support from connect page
- Make debugger page display stack even if libraries can't be loaded
- Fix reload of vm-connect page
- Fix polymer initialization calls

R=turnidge@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45390

[Cutch, 2015-04-22 23:57:38]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[turnidge, 2015-04-23 17:03:33]

lgtm w/ comments

great, great feature... I love it.

as discussed offline, you will wait for my outstanding CL to land and then patch
up....

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/app/page.dart (right):

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/app/page.dart:277: bool canVisit(Uri uri) =>
uri.path.startsWith('error');
We don't want to capture pages that look like this;  error-of-a-different-kind. 
Other canVisit methods have been updated to look like this:

bool canVisit(Uri uri) => uri.path == 'error';

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/app/page.dart:295: bool canVisit(Uri uri) =>
uri.path.startsWith('vm-connect');
Ditto comment above.  If you get rid of the '/', you need to switch startsWith
to == and test that it still works.  Otherwise unintended name capture.

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/debugger.dart:887: // Error loading
libraries, try and display stack.
I kinda think we should include the libs in the crash dump... your call though. 
Fine for now.

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/vm_connect.html (right):

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/vm_connect.html:71: <h2>Crash dump</h2>
Should we consider a different name?  These don't have to be used only for
crashes... can be decided later.

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:596: class FakeVM extends VM {
Lovely.  This is so slick.

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:608: String _canonicalizeUri(Uri
uri) {
Add comment to this function:

Canonicalize urls, as they are used in keys for blah or something...

https://codereview.chromium.org/1100583006/diff/60001/runtime/vm/debugger.h
File runtime/vm/debugger.h (right):

https://codereview.chromium.org/1100583006/diff/60001/runtime/vm/debugger.h#n...
runtime/vm/debugger.h:205: // the complete script, function, and, local variable
objects are included.
In a future CL, drop support for "full" and dump the ring... as discussed with
iposva offline.  Ok for now.

[Cutch, 2015-04-24 00:05:32]

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/app/page.dart (right):

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/app/page.dart:277: bool canVisit(Uri uri) =>
uri.path.startsWith('error');
On 2015/04/23 17:03:33, turnidge wrote:
> We don't want to capture pages that look like this; 
error-of-a-different-kind. 
> Other canVisit methods have been updated to look like this:
> 
> bool canVisit(Uri uri) => uri.path == 'error';

Done.

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/app/page.dart:295: bool canVisit(Uri uri) =>
uri.path.startsWith('vm-connect');
On 2015/04/23 17:03:33, turnidge wrote:
> Ditto comment above.  If you get rid of the '/', you need to switch startsWith
> to == and test that it still works.  Otherwise unintended name capture.

Done.

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/debugger.dart:887: // Error loading
libraries, try and display stack.
On 2015/04/23 17:03:33, turnidge wrote:
> I kinda think we should include the libs in the crash dump... your call
though. 
> Fine for now.

Acknowledged.

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/vm_connect.html (right):

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/vm_connect.html:71: <h2>Crash dump</h2>
On 2015/04/23 17:03:33, turnidge wrote:
> Should we consider a different name?  These don't have to be used only for
> crashes... can be decided later.

Acknowledged.

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/1100583006/diff/60001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:608: String _canonicalizeUri(Uri
uri) {
On 2015/04/23 17:03:33, turnidge wrote:
> Add comment to this function:
> 
> Canonicalize urls, as they are used in keys for blah or something...

Done.

https://codereview.chromium.org/1100583006/diff/60001/runtime/vm/debugger.h
File runtime/vm/debugger.h (right):

https://codereview.chromium.org/1100583006/diff/60001/runtime/vm/debugger.h#n...
runtime/vm/debugger.h:205: // the complete script, function, and, local variable
objects are included.
On 2015/04/23 17:03:33, turnidge wrote:
> In a future CL, drop support for "full" and dump the ring... as discussed with
> iposva offline.  Ok for now.

Acknowledged.

[Cutch, 2015-04-24 00:08:45]

Committed patchset #4 (id:60001) manually as 45390 (presubmit successful).