Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2334)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 1100583006: Add crash dumps to service protocol and Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index 7457b1d3828278ed168587fedbb028e3bea9cc55..e0fc2224eb8587bdb3fb180dc4049201a82102f1 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -113,7 +113,7 @@ class VMPage extends SimplePage {
serviceElement.object = vm;
}
}).catchError((e, stack) {
- Logger.root.severe('VMPage visit error: $e\n$stack');
+ Logger.root.severe('VMPage visit error: $e');
});
}
}
@@ -274,7 +274,7 @@ class ErrorViewPage extends Page {
}
// TODO(turnidge): How to test this page?
- bool canVisit(Uri uri) => uri.path.startsWith('error/');
+ bool canVisit(Uri uri) => uri.path.startsWith('error');
turnidge 2015/04/23 17:03:33 We don't want to capture pages that look like this
Cutch 2015/04/24 00:05:32 Done.
}
class VMConnectPage extends Page {
@@ -292,8 +292,7 @@ class VMConnectPage extends Page {
assert(canVisit(uri));
}
- // TODO(turnidge): Update this to not have the trailing slash.
- bool canVisit(Uri uri) => uri.path.startsWith('vm-connect/');
+ bool canVisit(Uri uri) => uri.path.startsWith('vm-connect');
turnidge 2015/04/23 17:03:33 Ditto comment above. If you get rid of the '/', y
Cutch 2015/04/24 00:05:32 Done.
}
class MetricsPage extends Page {

Powered by Google App Engine
This is Rietveld 408576698