Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: runtime/observatory/lib/src/elements/vm_connect.html

Issue 1100583006: Add crash dumps to service protocol and Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/vm_connect.html
diff --git a/runtime/observatory/lib/src/elements/vm_connect.html b/runtime/observatory/lib/src/elements/vm_connect.html
index d6448ffa96daad030b2fae712709bf2d72df796b..a7b30b1fa29e45459c2e88961ccd8378704a38f6 100644
--- a/runtime/observatory/lib/src/elements/vm_connect.html
+++ b/runtime/observatory/lib/src/elements/vm_connect.html
@@ -22,9 +22,7 @@
<template if="{{ !isCurrentTarget }}">
<a on-click="{{ connectToVm }}" _href="{{ gotoLink('/vm') }}">{{ target.name }}</a>
</template>
- <template if="{{ !isChromeTarget }}">
- <button class="delete-button" on-click="{{ deleteVm }}">&#10006; Remove</button>
- </template>
+ <button class="delete-button" on-click="{{ deleteVm }}">&#10006; Remove</button>
</span>
</template>
</polymer-element>
@@ -49,7 +47,7 @@
<hr>
<div class="flex-row">
<div class="flex-item-40-percent">
- <h2><img style="height: 48px" src="img/dart_icon.png">Standalone</h2>
+ <h2>WebSocket</h2>
<br>
<ul>
<template repeat="{{ target in app.targets.history }}">
@@ -70,21 +68,13 @@
<div class="flex-item-20-percent"></div>
<div class="flex-item-40-percent">
- <h2><img style="height: 48px" src="img/chromium_icon.png">Chromium</h2>
+ <h2>Crash dump</h2>
turnidge 2015/04/23 17:03:33 Should we consider a different name? These don't
Cutch 2015/04/24 00:05:32 Acknowledged.
+ <br>
+ <input type="file" id="crashDumpFile">
<br>
- <ul>
- <template repeat="{{ target in chromeTargets }}">
- <li><vm-connect-target target="{{ target }}"></vm-connect-target></li>
- </template>
- </ul>
- <hr>
- <form autocomplete="on">
- <input class="textbox" placeholder="localhost:9222" type="text" value="{{ chromiumAddress }}">
- <input class="button" type="submit" value="Get Tabs" on-click="{{ getTabs }}">
- </form>
<br>
- <pre class="well">Run Chromium with:
-'--remote-debugging-port=9222'</pre>
+ <pre class="well">Request a crash dump with:
+'curl localhost:8181/_getCrashDump > dump.json'</pre>
<hr>
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698