Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2345)

Unified Diff: runtime/observatory/lib/src/elements/debugger.dart

Issue 1100583006: Add crash dumps to service protocol and Observatory (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/debugger.dart
diff --git a/runtime/observatory/lib/src/elements/debugger.dart b/runtime/observatory/lib/src/elements/debugger.dart
index 965ea1cc966970bfb2903568423cc6206b322e3a..2098d9355d4fb92da2afbebb0dab2b5c3fe85bde 100644
--- a/runtime/observatory/lib/src/elements/debugger.dart
+++ b/runtime/observatory/lib/src/elements/debugger.dart
@@ -883,6 +883,11 @@ class ObservatoryDebugger extends Debugger {
_refreshStack(isolate.pauseEvent).then((_) {
reportStatus();
});
+ }).catchError((_) {
+ // Error loading libraries, try and display stack.
turnidge 2015/04/23 17:03:33 I kinda think we should include the libs in the cr
Cutch 2015/04/24 00:05:32 Acknowledged.
+ _refreshStack(isolate.pauseEvent).then((_) {
+ reportStatus();
+ });
});
});
} else {

Powered by Google App Engine
This is Rietveld 408576698