Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1096693005: Support @Skip as a suite-level annotation. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support @Skip as a suite-level annotation. Closes #14 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/8eaca5aee899e99ca6437da53915a4c34bd0733d

Patch Set 1 #

Total comments: 6

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -3 lines) Patch
M CHANGELOG.md View 1 1 chunk +6 lines, -0 lines 0 comments Download
M README.md View 1 chunk +43 lines, -0 lines 0 comments Download
A lib/src/frontend/skip.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M lib/src/runner/loader.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M lib/src/runner/parse_metadata.dart View 1 3 chunks +51 lines, -1 line 0 comments Download
M lib/test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/runner/parse_metadata_test.dart View 1 chunk +56 lines, -0 lines 0 comments Download
M test/runner/runner_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 8 months ago (2015-04-17 23:35:47 UTC) #1
kevmoo
LGTM, modulo nits https://codereview.chromium.org/1096693005/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1096693005/diff/1/CHANGELOG.md#newcode12 CHANGELOG.md:12: [custom html]: https://github.com/dart-lang/test/blob/master/README.md#skipping-tests You mean [skip] ...
5 years, 8 months ago (2015-04-17 23:56:29 UTC) #2
nweiz
Code review changes
5 years, 8 months ago (2015-04-18 00:07:34 UTC) #3
nweiz
https://codereview.chromium.org/1096693005/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1096693005/diff/1/CHANGELOG.md#newcode12 CHANGELOG.md:12: [custom html]: https://github.com/dart-lang/test/blob/master/README.md#skipping-tests On 2015/04/17 23:56:29, kevmoo wrote: > ...
5 years, 8 months ago (2015-04-18 00:07:39 UTC) #4
nweiz
5 years, 8 months ago (2015-04-18 00:10:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8eaca5aee899e99ca6437da53915a4c34bd0733d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698