Support @Skip as a suite-level annotation.

lib/src/runner/parse_metadata.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.runner.parse_metadata;
 
 import 'dart:io';
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/src/generated/ast.dart';
@@ skipping 14 matching lines @@
   "microseconds"
 ];
 
 /// Parse the test metadata for the test file at [path].
 ///
 /// Throws an [AnalysisError] if parsing fails or a [FormatException] if the
 /// test annotations are incorrect.
 Metadata parseMetadata(String path) {
   var timeout;
   var testOn;
+  var skip;
 
   var contents = new File(path).readAsStringSync();
   var directives = parseDirectives(contents, name: path).directives;
   var annotations = directives.isEmpty ? [] : directives.first.metadata;
 
   // We explicitly *don't* just look for "package:test" imports here,
   // because it could be re-exported from another library.
   var prefixes = directives.map((directive) {
     if (directive is! ImportDirective) return null;
     if (directive.prefix == null) return null;
@@ skipping 30 matching lines @@
             _spanFor(annotation, path));
       }
       testOn = _parseTestOn(annotation, constructorName, path);
     } else if (name == 'Timeout') {
       if (timeout != null) {
         throw new SourceSpanFormatException(
             "Only a single Timeout annotation may be used for a given test file.",
             _spanFor(annotation, path));
       }
       timeout = _parseTimeout(annotation, constructorName, path);
+    } else if (name == 'Skip') {
+      if (skip != null) {
+        throw new SourceSpanFormatException(
+            "Only a single Skip annotation may be used for a given test file.",
+            _spanFor(annotation, path));
+      }
+      skip = _parseSkip(annotation, constructorName, path);
     }
   }
 
   try {
     return new Metadata.parse(
         testOn: testOn == null ? null : testOn.stringValue,
-        timeout: timeout);
+        timeout: timeout,
+        skip: skip);
   } on SourceSpanFormatException catch (error) {
     var file = new SourceFile(new File(path).readAsStringSync(),
         url: p.toUri(path));
     var span = contextualizeSpan(error.span, testOn, file);
     if (span == null) rethrow;
     throw new SourceSpanFormatException(error.message, span);
   }
 }
 
 /// Parses a `@TestOn` annotation.
@@ skipping 79 matching lines @@
         _spanFor(annotation.arguments, path));
   }
 
   if (constructorName == null) {
     return new Timeout(_parseDuration(args.first, path));
   } else {
     return new Timeout.factor(_parseNum(args.first, path));
   }
 }
 
+/// Parses a `@Skip` annotation.
+///
+/// [annotation] is the annotation. [constructorName] is the name of the named
+/// constructor for the annotation, if any. [path] is the path to the file from
+/// which the annotation was parsed.
+_parseSkip(Annotation annotation, String constructorName, String path) {

[kevmoo, 2015/04/17 23:56:29]

Is this a String? Define (and document) return value

[nweiz, 2015/04/18 00:07:39]

Done.

+  if (constructorName != null) {
+    throw new SourceSpanFormatException(
+        'Skip doesn\'t have a constructor named "$constructorName".',
+        _spanFor(annotation, path));
+  }
+
+  if (annotation.arguments == null) {
+    throw new SourceSpanFormatException(
+        'Skip must have parentheses.', _spanFor(annotation, path));
+  }
+
+  var args = annotation.arguments.arguments;
+  if (args.length > 1) {
+    throw new SourceSpanFormatException(
+        'Skip takes zero arguments or one argument.',
+        _spanFor(annotation.arguments, path));
+  }
+
+  if (args.isEmpty) return true;
+
+  if (args.first is NamedExpression) {
+    throw new SourceSpanFormatException(
+        "Skip doesn't take named parameters.", _spanFor(args.first, path));
+  }
+
+  if (args.first is! StringLiteral) {
+    throw new SourceSpanFormatException(
+        "Skip takes a String.", _spanFor(args.first, path));
+  }
+
+  return args.first.stringValue;
+}
+
 /// Parses a `const Duration` expression.
 Duration _parseDuration(Expression expression, String path) {
   if (expression is! InstanceCreationExpression) {
     throw new SourceSpanFormatException(
         "Expected a Duration.",
         _spanFor(expression, path));
   }
 
   var constructor = expression as InstanceCreationExpression;
   if (constructor.constructorName.type.name.name != 'Duration') {
@@ skipping 64 matching lines @@
   throw new SourceSpanFormatException(
       "Expected an integer.", _spanFor(expression, path));
 }
 
 /// Creates a [SourceSpan] for [node].
 SourceSpan _spanFor(AstNode node, String path) =>
     // Load a SourceFile from scratch here since we're only ever going to emit
     // one error per file anyway.
     new SourceFile(new File(path).readAsStringSync(), url: p.toUri(path))
         .span(node.offset, node.end);