Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: test/runner/parse_metadata_test.dart

Issue 1096693005: Support @Skip as a suite-level annotation. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/test.dart ('k') | test/runner/runner_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/parse_metadata_test.dart
diff --git a/test/runner/parse_metadata_test.dart b/test/runner/parse_metadata_test.dart
index 03bcbc79acfebf1085dcb3757bc18330a8368318..3ac875db70b630e28566d80c3eaf647423024588 100644
--- a/test/runner/parse_metadata_test.dart
+++ b/test/runner/parse_metadata_test.dart
@@ -228,4 +228,60 @@ library foo;
});
});
});
+
+ group("@Skip:", () {
+ test("parses a valid annotation", () {
+ new File(_path).writeAsStringSync("@Skip()\nlibrary foo;");
+ var metadata = parseMetadata(_path);
+ expect(metadata.skip, isTrue);
+ expect(metadata.skipReason, isNull);
+ });
+
+ test("parses a valid annotation with a reason", () {
+ new File(_path).writeAsStringSync("@Skip('reason')\nlibrary foo;");
+ var metadata = parseMetadata(_path);
+ expect(metadata.skip, isTrue);
+ expect(metadata.skipReason, equals('reason'));
+ });
+
+ test("ignores a constructor named Skip", () {
+ new File(_path).writeAsStringSync("@foo.Skip('foo')\nlibrary foo;");
+ var metadata = parseMetadata(_path);
+ expect(metadata.skip, isFalse);
+ });
+
+ group("throws an error for", () {
+ test("a named constructor", () {
+ new File(_path).writeAsStringSync("@Skip.name('foo')\nlibrary foo;");
+ expect(() => parseMetadata(_path), throwsFormatException);
+ });
+
+ test("no argument list", () {
+ new File(_path).writeAsStringSync("@Skip\nlibrary foo;");
+ expect(() => parseMetadata(_path), throwsFormatException);
+ });
+
+ test("a named argument", () {
+ new File(_path).writeAsStringSync(
+ "@Skip(reason: 'foo')\nlibrary foo;");
+ expect(() => parseMetadata(_path), throwsFormatException);
+ });
+
+ test("multiple arguments", () {
+ new File(_path).writeAsStringSync("@Skip('foo', 'bar')\nlibrary foo;");
+ expect(() => parseMetadata(_path), throwsFormatException);
+ });
+
+ test("a non-string argument", () {
+ new File(_path).writeAsStringSync("@Skip(123)\nlibrary foo;");
+ expect(() => parseMetadata(_path), throwsFormatException);
+ });
+
+ test("multiple @Skips", () {
+ new File(_path).writeAsStringSync(
+ "@Skip('foo')\n@Skip('bar')\nlibrary foo;");
+ expect(() => parseMetadata(_path), throwsFormatException);
+ });
+ });
+ });
}
« no previous file with comments | « lib/test.dart ('k') | test/runner/runner_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698