Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: lib/src/runner/loader.dart

Issue 1096693005: Support @Skip as a suite-level annotation. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/frontend/skip.dart ('k') | lib/src/runner/parse_metadata.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/loader.dart
diff --git a/lib/src/runner/loader.dart b/lib/src/runner/loader.dart
index 7652165d1eaaaf90c8ecc144f71ed6435928a7e1..1b4aafa83bff29693e9556632b3b75b266e7589c 100644
--- a/lib/src/runner/loader.dart
+++ b/lib/src/runner/loader.dart
@@ -127,14 +127,15 @@ class Loader {
var controller = new StreamController();
Future.forEach(_platforms, (platform) {
if (!metadata.testOn.evaluate(platform, os: currentOS)) {
- return new Future.value();
+ return;
}
// Don't load a skipped suite.
if (metadata.skip) {
- return new Future.value(new Suite([
+ controller.add(new Suite([
new LocalTest(path, metadata, () {})
], path: path, platform: platform.name, metadata: metadata));
+ return;
}
return new Future.sync(() {
« no previous file with comments | « lib/src/frontend/skip.dart ('k') | lib/src/runner/parse_metadata.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698