Issue 10918212: Prohibit inlining of functions containing throw. Inliner does not handle abnormal control flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10918212: Prohibit inlining of functions containing throw. Inliner does not handle abnormal control flow. (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 3 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Prohibit inlining of functions containing throw. Inliner does not handle abnormal control flow. In StrictCompareInstr::Canonicalize don't remove right_constant from the graph. It might leave the graph in the inconsistent state. R=srdjan@google.com BUG=dart:5136 Committed: https://code.google.com/p/dart/source/detail?r=12497

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	runtime/vm/intermediate_language.cc	View		1 chunk	+0 lines, -3 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/10918212/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (left): https://codereview.chromium.org/10918212/diff/1/runtime/vm/intermediate_language.cc#oldcode1145 runtime/vm/intermediate_language.cc:1145: right_defn->RemoveFromGraph(); Why don't you remove the right hand ...

8 years, 3 months ago (2012-09-13 12:51:09 UTC) #2

Vyacheslav Egorov (Google)

8 years, 3 months ago (2012-09-13 13:15:57 UTC) #3

Thanks. Landing.

https://codereview.chromium.org/10918212/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (left):

https://codereview.chromium.org/10918212/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:1145: right_defn->RemoveFromGraph();
On 2012/09/13 12:51:09, srdjan wrote:
> Why don't you remove the right hand side?

It can still have uses. It's not for canonicalization pass to remove it. In any
case register allocator will ignore constants that are not used.

Expand Messages | Collapse Messages