runtime/vm/flow_graph_builder.cc - Issue 10918212: Prohibit inlining of functions containing throw. Inliner does not handle abnormal control flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10918212: Prohibit inlining of functions containing throw. Inliner does not handle abnormal control flow. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index bcd8440da5640113621497db3b33e20d194c8eb9..1dce574ef13705629ad0d1543bd7c7668fbe2f75 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -2535,6 +2535,9 @@ void EffectGraphVisitor::VisitTryCatchNode(TryCatchNode* node) {

void EffectGraphVisitor::BuildThrowNode(ThrowNode* node) {

+ // TODO(kmillikin) non-local control flow is not handled correctly

+ // by the inliner.

+ InlineBailout("EffectGraphVisitor::BuildThrowNode");

ValueGraphVisitor for_exception(owner(), temp_index());

node->exception()->Visit(&for_exception);

Append(for_exception);

« no previous file with comments | « no previous file | runtime/vm/intermediate_language.cc » ('j') | runtime/vm/intermediate_language.cc » ('J')