Prohibit inlining of functions containing throw. Inliner does not handle abnormal control flow.

runtime/vm/intermediate_language.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/intermediate_language.h"
 
 #include "vm/bit_vector.h"
 #include "vm/dart_entry.h"
 #include "vm/flow_graph_allocator.h"
 #include "vm/flow_graph_builder.h"
@@ skipping 1122 matching lines @@
 
 Definition* StrictCompareInstr::Canonicalize() {
   if (!right()->BindsToConstant()) return this;
   const Object& right_constant = right()->BoundConstant();
   Definition* left_defn = left()->definition();
   // TODO(fschneider): Handle other cases: e === false and e !== true/false.
   // Handles e === true.
   if ((kind() == Token::kEQ_STRICT) &&
       (right_constant.raw() == Bool::True()) &&
       (left()->ResultCid() == kBoolCid)) {
-    // Remove the constant from the graph.
-    Definition* right_defn = right()->definition();
-    right_defn->RemoveFromGraph();

[srdjan, 2012/09/13 12:51:09]

Why don't you remove the right hand side?

[Vyacheslav Egorov (Google), 2012/09/13 13:15:57]

It can still have uses. It's not for canonicalization pass to remove it. In any
case register allocator will ignore constants that are not used.

     // Return left subexpression as the replacement for this instruction.
     return left_defn;
   }
   return this;
 }
 
 
 Definition* CheckClassInstr::Canonicalize() {
   const intptr_t v_cid = value()->ResultCid();
   const intptr_t num_checks = unary_checks().NumberOfChecks();
@@ skipping 502 matching lines @@
     value->set_use_index(use_index++);
     value->AddToEnvUseList();
   }
   instr->set_env(copy);
 }
 
 
 #undef __
 
 }  // namespace dart