Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 10918212: Prohibit inlining of functions containing throw. Inliner does not handle abnormal control flow. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index c5b9ef62044b292083ecff0d5804b992ec6753d1..cb5a666e19ece8a4c866c119eb129a2197f23206 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -1140,9 +1140,6 @@ Definition* StrictCompareInstr::Canonicalize() {
if ((kind() == Token::kEQ_STRICT) &&
(right_constant.raw() == Bool::True()) &&
(left()->ResultCid() == kBoolCid)) {
- // Remove the constant from the graph.
- Definition* right_defn = right()->definition();
- right_defn->RemoveFromGraph();
srdjan 2012/09/13 12:51:09 Why don't you remove the right hand side?
Vyacheslav Egorov (Google) 2012/09/13 13:15:57 It can still have uses. It's not for canonicalizat
// Return left subexpression as the replacement for this instruction.
return left_defn;
}
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698