Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 10910253: Change RegExp constructor to insist on proper named optional parameters. (Closed)

Created:
8 years, 3 months ago by kasperl
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Change RegExp constructor to insist on proper named optional parameters. R=bak@google.com,lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12329

Patch Set 1 #

Patch Set 2 : Update co19 status. #

Patch Set 3 : Update co19/dart2js status. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -18 lines) Patch
M lib/compiler/implementation/lib/coreimpl_patch.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/lib/regexp_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/string_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/core/regexp.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/inline_parser.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/lib/regexp_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/markdown/inline_parser.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kasperl
8 years, 3 months ago (2012-09-13 12:31:54 UTC) #1
floitsch
8 years, 3 months ago (2012-09-13 12:43:24 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698