Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: lib/compiler/implementation/lib/string_helper.dart

Issue 10910253: Change RegExp constructor to insist on proper named optional parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update co19/dart2js status. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/lib/regexp_helper.dart ('k') | lib/core/regexp.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/lib/string_helper.dart
diff --git a/lib/compiler/implementation/lib/string_helper.dart b/lib/compiler/implementation/lib/string_helper.dart
index 06ad48291e8d3184ccb03ed04a841409a0ddc9cb..2f82469847b435a4c8003f7708b0433fae4d9f81 100644
--- a/lib/compiler/implementation/lib/string_helper.dart
+++ b/lib/compiler/implementation/lib/string_helper.dart
@@ -93,10 +93,10 @@ stringReplaceAllUnchecked(receiver, from, to) {
}
} else {
RegExp quoteRegExp =
- const JSSyntaxRegExp(@'[-[\]{}()*+?.,\\^$|#\s]', false, false);
+ const JSSyntaxRegExp(@'[-[\]{}()*+?.,\\^$|#\s]');
var quoter = regExpMakeNative(quoteRegExp, global: true);
var quoted = JS('String', @'#.replace(#, "\\$&")', from, quoter);
- RegExp replaceRegExp = new JSSyntaxRegExp(quoted, false, false);
+ RegExp replaceRegExp = new JSSyntaxRegExp(quoted);
var replacer = regExpMakeNative(replaceRegExp, global: true);
return stringReplaceJS(receiver, replacer, to);
}
« no previous file with comments | « lib/compiler/implementation/lib/regexp_helper.dart ('k') | lib/core/regexp.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698