lib/compiler/implementation/lib/regexp_helper.dart - Issue 10910253: Change RegExp constructor to insist on proper named optional parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/lib/regexp_helper.dart

Issue 10910253: Change RegExp constructor to insist on proper named optional parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update co19/dart2js status. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/lib/regexp_helper.dart

diff --git a/lib/compiler/implementation/lib/regexp_helper.dart b/lib/compiler/implementation/lib/regexp_helper.dart

index d8bc803320ceeb7b1ce90b9f2be020d755fdd5c9..72a9f96df454cdaf9338fcc193e980cbb675b74b 100644

--- a/lib/compiler/implementation/lib/regexp_helper.dart

+++ b/lib/compiler/implementation/lib/regexp_helper.dart

@@ -6,7 +6,7 @@ List regExpExec(JSSyntaxRegExp regExp, String str) {

var nativeRegExp = regExpGetNative(regExp);

var result = JS('List', @'#.exec(#)', nativeRegExp, str);

if (JS('bool', @'# === null', result)) return null;

- return result;

+ return result;

}

bool regExpTest(JSSyntaxRegExp regExp, String str) {

« no previous file with comments | « lib/compiler/implementation/lib/coreimpl_patch.dart ('k') | lib/compiler/implementation/lib/string_helper.dart » ('j') | no next file with comments »