Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: lib/compiler/implementation/lib/coreimpl_patch.dart

Issue 10910253: Change RegExp constructor to insist on proper named optional parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update co19/dart2js status. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/lib/regexp_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/lib/coreimpl_patch.dart
diff --git a/lib/compiler/implementation/lib/coreimpl_patch.dart b/lib/compiler/implementation/lib/coreimpl_patch.dart
index 21acf728155f895cc65e7a322770904cd0d3b987..477749b85e27fe35d31654882f4b3a5537bf27d9 100644
--- a/lib/compiler/implementation/lib/coreimpl_patch.dart
+++ b/lib/compiler/implementation/lib/coreimpl_patch.dart
@@ -146,8 +146,8 @@ patch class JSSyntaxRegExp {
final bool _ignoreCase;
patch const JSSyntaxRegExp(String pattern,
- [bool multiLine = false,
- bool ignoreCase = false])
+ {bool multiLine: false,
+ bool ignoreCase: false})
: _pattern = pattern,
_multiLine = multiLine,
_ignoreCase = ignoreCase;
@@ -179,8 +179,8 @@ patch class JSSyntaxRegExp {
static JSSyntaxRegExp _globalVersionOf(JSSyntaxRegExp other) {
JSSyntaxRegExp re = new JSSyntaxRegExp(other.pattern,
- other.multiLine,
- other.ignoreCase);
+ multiLine: other.multiLine,
+ ignoreCase: other.ignoreCase);
regExpAttachGlobalNative(re);
return re;
}
« no previous file with comments | « no previous file | lib/compiler/implementation/lib/regexp_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698