Chromium Code Reviews

Issue 1083433002: More gracefully handle load errors. (Closed)

Created:
5 years, 8 months ago by nweiz
Modified:
5 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Stats (+308 lines, -167 lines)
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments
M lib/src/executable.dart View 7 chunks +35 lines, -41 lines 0 comments
A lib/src/runner/load_exception_suite.dart View 1 chunk +25 lines, -0 lines 0 comments
M lib/src/runner/loader.dart View 3 chunks +33 lines, -20 lines 0 comments
M lib/src/runner/reporter/compact.dart View 4 chunks +21 lines, -2 lines 0 comments
M test/runner/browser/compiler_pool_test.dart View 4 chunks +3 lines, -4 lines 0 comments
M test/runner/browser/loader_test.dart View 3 chunks +4 lines, -3 lines 0 comments
M test/runner/browser/runner_test.dart View 5 chunks +34 lines, -19 lines 0 comments
M test/runner/loader_test.dart View 4 chunks +8 lines, -6 lines 0 comments
M test/runner/pub_serve_test.dart View 4 chunks +37 lines, -27 lines 0 comments
M test/runner/runner_test.dart View 12 chunks +105 lines, -45 lines 0 comments

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 8 months ago (2015-04-10 20:48:17 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/1083433002/diff/1/test/runner/browser/compiler_pool_test.dart File test/runner/browser/compiler_pool_test.dart (right): https://codereview.chromium.org/1083433002/diff/1/test/runner/browser/compiler_pool_test.dart#newcode10 test/runner/browser/compiler_pool_test.dart:10: import 'package:test/src/util/exit_codes.dart' as exit_codes; now unused https://codereview.chromium.org/1083433002/diff/1/test/runner/runner_test.dart File ...
5 years, 8 months ago (2015-04-10 21:23:32 UTC) #2
nweiz
Code review changes
5 years, 8 months ago (2015-04-10 21:54:00 UTC) #3
nweiz
https://codereview.chromium.org/1083433002/diff/1/test/runner/browser/compiler_pool_test.dart File test/runner/browser/compiler_pool_test.dart (right): https://codereview.chromium.org/1083433002/diff/1/test/runner/browser/compiler_pool_test.dart#newcode10 test/runner/browser/compiler_pool_test.dart:10: import 'package:test/src/util/exit_codes.dart' as exit_codes; On 2015/04/10 21:23:32, kevmoo wrote: ...
5 years, 8 months ago (2015-04-10 21:54:58 UTC) #4
nweiz
5 years, 8 months ago (2015-04-10 21:55:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
3d3fee76f67fd0d2fc407661fc3b0b1b751a8617 (presubmit successful).

Powered by Google App Engine