More gracefully handle load errors.

test/runner/runner_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 @TestOn("vm")
 
 import 'dart:io';
 import 'dart:math' as math;
 
 import 'package:path/path.dart' as p;
 import 'package:test/src/util/exit_codes.dart' as exit_codes;

[kevmoo, 2015/04/10 21:23:32]

now unused

[nweiz, 2015/04/10 21:54:57]

Done.

 import 'package:test/src/util/io.dart';
 import 'package:test/test.dart';
 
 import '../io.dart';
 
 String _sandbox;
 
 final _success = """
 import 'dart:async';
 
@@ skipping 58 matching lines @@
       var result = _runUnittest(["--asdf"]);
       expect(result.stderr, equals("""
 Could not find an option named "asdf".
 
 $_usage"""));
       expect(result.exitCode, equals(exit_codes.usage));
     });
 
     test("a non-existent file is passed", () {
       var result = _runUnittest(["file"]);
-      expect(result.stderr, equals('Failed to load "file": Does not exist.\n'));
-      expect(result.exitCode, equals(exit_codes.data));
+      expect(result.stdout, allOf([
+        contains('-1: load error'),
+        contains('Failed to load "file": Does not exist.')
+      ]));
+      expect(result.exitCode, equals(1));
     });
 
     test("the default directory doesn't exist", () {
       var result = _runUnittest([]);
-      expect(result.stderr, equals(
-          'Failed to load "test": No test files were passed and the default '
-              'directory doesn\'t exist.\n'));
+      expect(result.stderr, equals("""
+No test files were passed and the default "test/" directory doesn't exist.
+
+$_usage"""));
       expect(result.exitCode, equals(exit_codes.data));
     });
 
     test("a test file fails to load", () {
       var testPath = p.join(_sandbox, "test.dart");
       new File(testPath).writeAsStringSync("invalid Dart file");
       var result = _runUnittest(["test.dart"]);
 
-      expect(result.stderr, equals(
-          'Failed to load "${p.relative(testPath, from: _sandbox)}":\n'
-          "line 1 pos 1: unexpected token 'invalid'\n"
-          "invalid Dart file\n"
-          "^\n"));
-      expect(result.exitCode, equals(exit_codes.data));
+      expect(result.stdout, allOf([
+        contains('-1: load error'),
+        contains(
+          '  Failed to load "${p.relative(testPath, from: _sandbox)}":\n'
+          "  line 1 pos 1: unexpected token 'invalid'\n"
+          "  invalid Dart file\n"
+          "  ^\n")
+      ]));
+      expect(result.exitCode, equals(1));
     });
 
     // This is slightly different from the above test because it's an error
     // that's caught first by the analyzer when it's used to parse the file.
     test("a test file fails to parse", () {
       var testPath = p.join(_sandbox, "test.dart");
       new File(testPath).writeAsStringSync("@TestOn)");
       var result = _runUnittest(["test.dart"]);
 
-      expect(result.stderr, equals(
-          'Failed to load "${p.relative(testPath, from: _sandbox)}":\n'
-          "line 1 pos 8: unexpected token ')'\n"
-          "@TestOn)\n"
-          "       ^\n"));
-      expect(result.exitCode, equals(exit_codes.data));
+      expect(result.stdout, allOf([
+        contains('-1: load error'),
+        contains(
+          '  Failed to load "${p.relative(testPath, from: _sandbox)}":\n'
+          "  line 1 pos 8: unexpected token ')'\n"
+          "  @TestOn)\n"
+          "         ^\n")
+      ]));
+      expect(result.exitCode, equals(1));
     });
 
     test("an annotation's structure is invalid", () {
       var testPath = p.join(_sandbox, "test.dart");
       new File(testPath).writeAsStringSync("@TestOn()\nlibrary foo;");
       var result = _runUnittest(["test.dart"]);
 
-      expect(result.stderr, equals(
-          'Failed to load "${p.relative(testPath, from: _sandbox)}":\n'
-          "Error on line 1, column 8: TestOn takes one argument.\n"
-          "@TestOn()\n"
-          "       ^^\n"));
-      expect(result.exitCode, equals(exit_codes.data));
+      expect(result.stdout, allOf([
+        contains('-1: load error'),
+        contains(
+          '  Failed to load "${p.relative(testPath, from: _sandbox)}":\n'
+          "  Error on line 1, column 8: TestOn takes one argument.\n"
+          "  @TestOn()\n"
+          "         ^^\n")
+      ]));
+      expect(result.exitCode, equals(1));
     });
 
     test("an annotation's contents are invalid", () {
       var testPath = p.join(_sandbox, "test.dart");
       new File(testPath).writeAsStringSync("@TestOn('zim')\nlibrary foo;");
       var result = _runUnittest(["test.dart"]);
 
-      expect(result.stderr, equals(
-          'Failed to load "${p.relative(testPath, from: _sandbox)}":\n'
-          "Error on line 1, column 10: Undefined variable.\n"
-          "@TestOn('zim')\n"
-          "         ^^^\n"));
-      expect(result.exitCode, equals(exit_codes.data));
+      expect(result.stdout, allOf([
+        contains('-1: load error'),
+        contains(
+          '  Failed to load "${p.relative(testPath, from: _sandbox)}":\n'
+          "  Error on line 1, column 10: Undefined variable.\n"
+          "  @TestOn('zim')\n"
+          "           ^^^\n")
+      ]));
+      expect(result.exitCode, equals(1));
     });
 
     test("a test file throws", () {
       var testPath = p.join(_sandbox, "test.dart");
       new File(testPath).writeAsStringSync("void main() => throw 'oh no';");
 
       var result = _runUnittest(["test.dart"]);
-      expect(result.stderr, startsWith(
-          'Failed to load "${p.relative(testPath, from: _sandbox)}": oh no\n'));
-      expect(result.exitCode, equals(exit_codes.data));
+      expect(result.stdout, allOf([
+        contains('-1: load error'),
+        contains(
+            'Failed to load "${p.relative(testPath, from: _sandbox)}": oh no')
+      ]));
+      expect(result.exitCode, equals(1));
     });
 
     test("a test file doesn't have a main defined", () {
       var testPath = p.join(_sandbox, "test.dart");
       new File(testPath).writeAsStringSync("void foo() {}");
 
       var result = _runUnittest(["test.dart"]);
-      expect(result.stderr, startsWith(
-          'Failed to load "${p.relative(testPath, from: _sandbox)}": No '
-              'top-level main() function defined.\n'));
-      expect(result.exitCode, equals(exit_codes.data));
+      expect(result.stdout, allOf([
+        contains('-1: load error'),
+        contains(
+            'Failed to load "${p.relative(testPath, from: _sandbox)}": No '
+                'top-level main() function defined.')
+      ]));
+      expect(result.exitCode, equals(1));
     });
 
     test("a test file has a non-function main", () {
       var testPath = p.join(_sandbox, "test.dart");
       new File(testPath).writeAsStringSync("int main;");
 
       var result = _runUnittest(["test.dart"]);
-      expect(result.stderr, startsWith(
-          'Failed to load "${p.relative(testPath, from: _sandbox)}": Top-level '
-              'main getter is not a function.\n'));
-      expect(result.exitCode, equals(exit_codes.data));
+      expect(result.stdout, allOf([
+        contains('-1: load error'),
+        contains(
+            'Failed to load "${p.relative(testPath, from: _sandbox)}": '
+                'Top-level main getter is not a function.')
+      ]));
+      expect(result.exitCode, equals(1));
     });
 
     test("a test file has a main with arguments", () {
       var testPath = p.join(_sandbox, "test.dart");
       new File(testPath).writeAsStringSync("void main(arg) {}");
 
       var result = _runUnittest(["test.dart"]);
-      expect(result.stderr, startsWith(
-          'Failed to load "${p.relative(testPath, from: _sandbox)}": Top-level '
-              'main() function takes arguments.\n'));
-      expect(result.exitCode, equals(exit_codes.data));
+      expect(result.stdout, allOf([
+        contains('-1: load error'),
+        contains(
+            'Failed to load "${p.relative(testPath, from: _sandbox)}": '
+                'Top-level main() function takes arguments.')
+      ]));
+      expect(result.exitCode, equals(1));
+    });
+
+    test("multiple load errors occur", () {
+      var testPath = p.join(_sandbox, "test.dart");
+      new File(testPath).writeAsStringSync("invalid Dart file");
+      var result = _runUnittest(["test.dart", "nonexistent.dart"]);
+
+      expect(result.stdout, allOf([
+        contains('test.dart: load error'),
+        contains(
+          '  Failed to load "test.dart":\n'
+          "  line 1 pos 1: unexpected token 'invalid'\n"
+          "  invalid Dart file\n"
+          "  ^\n"),
+        contains('nonexistent.dart: load error'),
+        contains('Failed to load "nonexistent.dart": Does not exist.')
+      ]));
     });
 
     // TODO(nweiz): test what happens when a test file is unreadable once issue
     // 15078 is fixed.
   });
 
   group("runs successful tests", () {
     test("defined in a single file", () {
       new File(p.join(_sandbox, "test.dart")).writeAsStringSync(_success);
       var result = _runUnittest(["test.dart"]);
@@ skipping 62 matching lines @@
     test("directly", () {
       new File(p.join(_sandbox, "test.dart")).writeAsStringSync(_failure);
       var result = _runDart([
         "--package-root=${p.join(packageDir, 'packages')}",
         "test.dart"
       ]);
       expect(result.stdout, contains("Some tests failed."));
     });
   });
 
+  test("runs tests even when a file fails to load", () {
+    new File(p.join(_sandbox, "test.dart")).writeAsStringSync(_success);
+    var result = _runUnittest(["test.dart", "nonexistent.dart"]);
+    expect(result.stdout, contains("+1 -1: Some tests failed."));
+    expect(result.exitCode, equals(1));
+  });
+
   group("flags:", () {
     test("with the --color flag, uses colors", () {
       new File(p.join(_sandbox, "test.dart")).writeAsStringSync(_failure);
       var result = _runUnittest(["--color", "test.dart"]);
       // This is the color code for red.
       expect(result.stdout, contains("\u001b[31m"));
     });
 
     group("with the --name flag,", () {
       test("selects tests with matching names", () {
@@ skipping 33 matching lines @@
       });
 
       test("produces an error when no tests match", () {
         new File(p.join(_sandbox, "test.dart")).writeAsStringSync(_success);
 
         var result = _runUnittest(["--name", "no match", "test.dart"]);
         expect(result.stderr,
             contains('No tests match regular expression "no match".'));
         expect(result.exitCode, equals(exit_codes.data));
       });
+
+      test("doesn't filter out load exceptions", () {
+        var result = _runUnittest(["--name", "name", "file"]);
+        expect(result.stdout, allOf([
+          contains('-1: load error'),
+          contains('Failed to load "file": Does not exist.')
+        ]));
+        expect(result.exitCode, equals(1));
+      });
     });
 
     group("with the --plain-name flag,", () {
       test("selects tests with matching names", () {
         new File(p.join(_sandbox, "test.dart")).writeAsStringSync("""
 import 'dart:async';
 
 import 'package:test/test.dart';
 
 void main() {
@@ skipping 36 matching lines @@
       });
     });
   });
 }
 
 ProcessResult _runUnittest(List<String> args) =>
     runUnittest(args, workingDirectory: _sandbox);
 
 ProcessResult _runDart(List<String> args) =>
     runDart(args, workingDirectory: _sandbox);