Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: test/runner/browser/compiler_pool_test.dart

Issue 1083433002: More gracefully handle load errors. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/reporter/compact.dart ('k') | test/runner/browser/loader_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/browser/compiler_pool_test.dart
diff --git a/test/runner/browser/compiler_pool_test.dart b/test/runner/browser/compiler_pool_test.dart
index 6b05a3a15d22e01639d0acd39c171533fdf90b8b..744b1329b851e27054162b01a69ebfec14d1edf1 100644
--- a/test/runner/browser/compiler_pool_test.dart
+++ b/test/runner/browser/compiler_pool_test.dart
@@ -7,7 +7,6 @@
import 'dart:io';
import 'package:path/path.dart' as p;
-import 'package:test/src/util/exit_codes.dart' as exit_codes;
import 'package:test/src/util/io.dart';
import 'package:test/test.dart';
@@ -33,7 +32,7 @@ void main() {
new File(testPath2).writeAsStringSync("int main() => 'foo';\n");
var result = _runUnittest(["-p", "chrome", "test1.dart", "test2.dart"]);
- expect(result.stdout, equals("""
+ expect(result.stdout, startsWith("""
Compiling test1.dart...
test1.dart:1:18:
Warning: 'int' is not assignable to 'String'.
@@ -45,7 +44,7 @@ Warning: 'String' is not assignable to 'int'.
int main() => 'foo';
^^^^^
"""));
- expect(result.exitCode, equals(exit_codes.data));
+ expect(result.exitCode, equals(1));
});
test("uses colors if the test runner uses colors", () {
@@ -54,7 +53,7 @@ int main() => 'foo';
var result = _runUnittest(["--color", "-p", "chrome", "test.dart"]);
expect(result.stdout, contains('\u001b[35m'));
- expect(result.exitCode, equals(exit_codes.data));
+ expect(result.exitCode, equals(1));
});
}
« no previous file with comments | « lib/src/runner/reporter/compact.dart ('k') | test/runner/browser/loader_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698