Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: test/runner/browser/loader_test.dart

Issue 1083433002: More gracefully handle load errors. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/runner/browser/compiler_pool_test.dart ('k') | test/runner/browser/runner_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/browser/loader_test.dart
diff --git a/test/runner/browser/loader_test.dart b/test/runner/browser/loader_test.dart
index e1a7d6657eb97474a45f444f1476a19c3d3dc38d..a3e93c5fe2c20cf6c957a3bdfd187a174a38bf39 100644
--- a/test/runner/browser/loader_test.dart
+++ b/test/runner/browser/loader_test.dart
@@ -49,7 +49,8 @@ void main() {
group(".loadFile()", () {
var suite;
setUp(() {
- return _loader.loadFile(p.join(_sandbox, 'a_test.dart')).then((suites) {
+ return _loader.loadFile(p.join(_sandbox, 'a_test.dart')).toList()
+ .then((suites) {
expect(suites, hasLength(1));
suite = suites.first;
});
@@ -89,7 +90,7 @@ void main() {
test("throws a nice error if the package root doesn't exist", () {
var loader = new Loader([TestPlatform.chrome]);
expect(
- loader.loadFile(p.join(_sandbox, 'a_test.dart'))
+ loader.loadFile(p.join(_sandbox, 'a_test.dart')).first
.whenComplete(loader.close),
throwsA(isLoadException(
"Directory ${p.join(_sandbox, 'packages')} does not exist.")));
@@ -99,7 +100,7 @@ void main() {
var loader = new Loader([TestPlatform.vm, TestPlatform.chrome],
packageRoot: p.join(packageDir, 'packages'));
var path = p.join(_sandbox, 'a_test.dart');
- return loader.loadFile(path).then((suites) {
+ return loader.loadFile(path).toList().then((suites) {
expect(suites[0].platform, equals('VM'));
expect(suites[0].path, equals(path));
expect(suites[1].platform, equals('Chrome'));
« no previous file with comments | « test/runner/browser/compiler_pool_test.dart ('k') | test/runner/browser/runner_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698