Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1076003004: Fix all Observatory warnings/errors. (Closed)

Created:
5 years, 8 months ago by turnidge
Modified:
5 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix all Observatory warnings/errors. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=45032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -53 lines) Patch
M runtime/observatory/lib/src/cli/command.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/debugger/source_location.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 3 chunks +15 lines, -16 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_profile.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/isolate_summary.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 4 chunks +10 lines, -7 lines 0 comments Download
M runtime/observatory/test/async_generator_breakpoint_test.dart View 3 chunks +10 lines, -11 lines 0 comments Download
M runtime/observatory/test/caching_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/test/call_site_data_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/test/classes_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/test/code_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/test/coverage_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/test/debugging_test.dart View 4 chunks +0 lines, -4 lines 0 comments Download
M runtime/observatory/test/eval_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/test/isolate_lifecycle_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/observatory/test/test_helper.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 8 months ago (2015-04-09 20:23:37 UTC) #2
Cutch
lgtm
5 years, 8 months ago (2015-04-09 20:29:45 UTC) #3
turnidge
5 years, 8 months ago (2015-04-09 20:31:21 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 45032 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698