Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: runtime/observatory/lib/src/debugger/source_location.dart

Issue 1076003004: Fix all Observatory warnings/errors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of debugger; 5 part of debugger;
6 6
7 class SourceLocation { 7 class SourceLocation {
8 SourceLocation.file(this.script, this.line, this.col); 8 SourceLocation.file(this.script, this.line, this.col);
9 SourceLocation.func(this.function); 9 SourceLocation.func(this.function);
10 SourceLocation.error(this.errorMessage); 10 SourceLocation.error(this.errorMessage);
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 matches.add(cls); 180 matches.add(cls);
181 } 181 }
182 } 182 }
183 } 183 }
184 } 184 }
185 return matches; 185 return matches;
186 }); 186 });
187 } 187 }
188 188
189 static ServiceFunction _getConstructor(Class cls, String name) { 189 static ServiceFunction _getConstructor(Class cls, String name) {
190 var matches = [];
191 for (var function in cls.functions) { 190 for (var function in cls.functions) {
192 assert(cls.loaded); 191 assert(cls.loaded);
193 if (name == function.name) { 192 if (name == function.name) {
194 return function; 193 return function;
195 } 194 }
196 } 195 }
197 return null; 196 return null;
198 } 197 }
199 198
200 // TODO(turnidge): This does not handle named functions which are 199 // TODO(turnidge): This does not handle named functions which are
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 return 'invalid source location (${errorMessage})'; 357 return 'invalid source location (${errorMessage})';
359 } 358 }
360 359
361 Script script; 360 Script script;
362 int line; 361 int line;
363 int col; 362 int col;
364 ServiceFunction function; 363 ServiceFunction function;
365 String errorMessage; 364 String errorMessage;
366 bool get valid => (errorMessage == null); 365 bool get valid => (errorMessage == null);
367 } 366 }
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/cli/command.dart ('k') | runtime/observatory/lib/src/elements/cpu_profile.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698