Fix all Observatory warnings/errors.

runtime/observatory/lib/src/service/object.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of service;
 
 /// A [ServiceObject] represents a persistent object within the vm.
 abstract class ServiceObject extends Observable {
   static int LexicalSortName(ServiceObject o1, ServiceObject o2) {
     return o1.name.compareTo(o2.name);
@@ skipping 359 matching lines @@
       new StreamController.broadcast();
 
   void postServiceEvent(String response, ByteData data) {
     var map;
     try {
       map = _parseJSON(response);
       assert(!map.containsKey('_data'));
       if (data != null) {
         map['_data'] = data;
       }
-    } catch (e, st) {
+    } catch (_) {
       Logger.root.severe('Ignoring malformed event response: ${response}');
       return;
     }
     if (map['type'] != 'ServiceEvent') {
       Logger.root.severe(
           "Expected 'ServiceEvent' but found '${map['type']}'");
       return;
     }
 
     var eventIsolate = map['isolate'];
@@ skipping 1502 matching lines @@
     name = map['name'];
     vmName = (map.containsKey('vmName') ? map['vmName'] : name);
 
     _upgradeCollection(map, isolate);
 
     dartOwner = map['owner'];
     kind = FunctionKind.fromJSON(map['kind']);
     isDart = !kind.isSynthetic();
 
     if (dartOwner is ServiceFunction) {
-      library = dartOwner.library;
-      qualifiedName = "${dartOwner.qualifiedName}.${name}";
+      ServiceFunction ownerFunction = dartOwner;
+      library = ownerFunction.library;
+      qualifiedName = "${ownerFunction.qualifiedName}.${name}";
 
     } else if (dartOwner is Class) {
-      library = dartOwner.library;
-      qualifiedName = "${dartOwner.name}.${name}";
+      Class ownerClass = dartOwner;
+      library = ownerClass.library;
+      qualifiedName = "${ownerClass.name}.${name}";
 
     } else {
       library = dartOwner;
       qualifiedName = name;
     }
 
     if (mapIsRef) {
       return;
     }
 
@@ skipping 40 matching lines @@
     name = map['name'];
     vmName = (map.containsKey('vmName') ? map['vmName'] : name);
     dartOwner = map['owner'];
     declaredType = map['declaredType'];
     isStatic = map['static'];
     isFinal = map['final'];
     isConst = map['const'];
     value = map['value'];
 
     if (dartOwner is Class) {
-      library = dartOwner.library;
+      Class ownerClass = dartOwner;
+      library = ownerClass.library;
 
     } else {
       library = dartOwner;
     }
 
     if (mapIsRef) {
       return;
     }
 
     guardNullable = map['_guardNullable'];
     guardClass = map['_guardClass'];
     guardLength = map['_guardLength'];
     script = map['script'];
     tokenPos = map['tokenPos'];
 
     _loaded = true;
   }
 
-  String toString() => 'Field(${darOwner.name}.$name)';
+  String toString() => 'Field(${dartOwner.name}.$name)';
 }
 
 
 class ScriptLine extends Observable {
   final Script script;
   final int line;
   final String text;
   @observable int hits;
   @observable bool possibleBpt = true;
   @observable bool breakpointResolved = false;
@@ skipping 938 matching lines @@
     var v = list[i];
     if ((v is ObservableMap) && _isServiceMap(v)) {
       list[i] = owner.getFromMap(v);
     } else if (v is ObservableList) {
       _upgradeObservableList(v, owner);
     } else if (v is ObservableMap) {
       _upgradeObservableMap(v, owner);
     }
   }
 }