Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1076003004: Fix all Observatory warnings/errors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index a358c8cc29999affb7d808d11da4b0c656dc1eeb..cc233f9daae59f40a4ebd8fd22283fe6479da2a8 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -377,7 +377,7 @@ abstract class VM extends ServiceObjectOwner {
if (data != null) {
map['_data'] = data;
}
- } catch (e, st) {
+ } catch (_) {
Logger.root.severe('Ignoring malformed event response: ${response}');
return;
}
@@ -1900,12 +1900,14 @@ class ServiceFunction extends ServiceObject with Coverage {
isDart = !kind.isSynthetic();
if (dartOwner is ServiceFunction) {
- library = dartOwner.library;
- qualifiedName = "${dartOwner.qualifiedName}.${name}";
+ ServiceFunction ownerFunction = dartOwner;
+ library = ownerFunction.library;
+ qualifiedName = "${ownerFunction.qualifiedName}.${name}";
} else if (dartOwner is Class) {
- library = dartOwner.library;
- qualifiedName = "${dartOwner.name}.${name}";
+ Class ownerClass = dartOwner;
+ library = ownerClass.library;
+ qualifiedName = "${ownerClass.name}.${name}";
} else {
library = dartOwner;
@@ -1966,7 +1968,8 @@ class Field extends ServiceObject {
value = map['value'];
if (dartOwner is Class) {
- library = dartOwner.library;
+ Class ownerClass = dartOwner;
+ library = ownerClass.library;
} else {
library = dartOwner;
@@ -1985,7 +1988,7 @@ class Field extends ServiceObject {
_loaded = true;
}
- String toString() => 'Field(${darOwner.name}.$name)';
+ String toString() => 'Field(${dartOwner.name}.$name)';
}

Powered by Google App Engine
This is Rietveld 408576698