Tidy up the service protocol. Begin improving the documentation.

Tidy up the service protocol.  Begin improving the documentation.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=44865

[turnidge, 2015-04-02 17:55:43]

turnidge@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-04-02 18:11:42]

LGTMwC

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1614: JSONObject typeargsRef(&jsobj,
"canonicalTypeArguments");
please remove

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service.idl
File runtime/vm/service/service.idl (right):

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.idl:10: setName(name string) Response
add missing isolateId

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.idl:166: isolate string
s/string/isolateRef

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.idl:264: startTime int
should we make a distinct type, e.g. "millisecondsSinceEpoch" or just
"milliseconds" (since epoch implied) ?

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.idl:332: // placeholder
globally: s/placeholder/TODO ?

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.idl:374: // A unique identifier for an object. 
Passed to <code>getObject</code> to load the full object.
column limit.

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.idl:699: value float
why the switch from double to float?

[turnidge, 2015-04-02 18:27:30]

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1614: JSONObject typeargsRef(&jsobj,
"canonicalTypeArguments");
On 2015/04/02 18:11:41, Cutch wrote:
> please remove

Done.

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service.idl
File runtime/vm/service/service.idl (right):

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.idl:10: setName(name string) Response
On 2015/04/02 18:11:41, Cutch wrote:
> add missing isolateId

Done.

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.idl:166: isolate string
On 2015/04/02 18:11:41, Cutch wrote:
> s/string/isolateRef

Nice catch.  Done.

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.idl:264: startTime int
On 2015/04/02 18:11:41, Cutch wrote:
> should we make a distinct type, e.g. "millisecondsSinceEpoch" or just
> "milliseconds" (since epoch implied) ?

Acknowledged.

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.idl:332: // placeholder
On 2015/04/02 18:11:41, Cutch wrote:
> globally: s/placeholder/TODO ?

Done.

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.idl:374: // A unique identifier for an object. 
Passed to <code>getObject</code> to load the full object.
On 2015/04/02 18:11:41, Cutch wrote:
> column limit.

Done.

https://codereview.chromium.org/1053053002/diff/1/runtime/vm/service/service....
runtime/vm/service/service.idl:699: value float
On 2015/04/02 18:11:41, Cutch wrote:
> why the switch from double to float?

The tool expects this.

[turnidge, 2015-04-02 19:16:47]

Committed patchset #3 (id:40001) manually as 44865 (presubmit successful).