Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: runtime/vm/service.cc

Issue 1053053002: Tidy up the service protocol. Begin improving the documentation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service/service.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 0a59f071f5621def10d86eba7b4f3cd03d58e13a..14c5efae67ca53dff22341ade2baca33f57123cd 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2438,7 +2438,6 @@ static const MethodParameter* get_vm_params[] = {
static bool GetVM(Isolate* isolate, JSONStream* js) {
JSONObject jsobj(js);
jsobj.AddProperty("type", "VM");
- jsobj.AddProperty("id", "vm");
jsobj.AddProperty("architectureBits", static_cast<intptr_t>(kBitsPerWord));
jsobj.AddProperty("targetCPU", CPU::Id());
jsobj.AddProperty("hostCPU", HostCPUFeatures::hardware());
@@ -2447,11 +2446,10 @@ static bool GetVM(Isolate* isolate, JSONStream* js) {
// pids > 53-bits (when consumed by JavaScript).
// TODO(johnmccutchan): Codify how integers are sent across the service.
jsobj.AddPropertyF("pid", "%" Pd "", OS::ProcessId());
- jsobj.AddProperty("assertsEnabled", isolate->AssertsEnabled());
- jsobj.AddProperty("typeChecksEnabled", isolate->TypeChecksEnabled());
+ jsobj.AddProperty("_assertsEnabled", isolate->AssertsEnabled());
+ jsobj.AddProperty("_typeChecksEnabled", isolate->TypeChecksEnabled());
int64_t start_time_millis = (Dart::vm_isolate()->start_time() /
kMicrosecondsPerMillisecond);
- jsobj.AddProperty64("refreshTime", OS::GetCurrentTimeMillis());
jsobj.AddProperty64("startTime", start_time_millis);
// Construct the isolate list.
{
@@ -2547,7 +2545,7 @@ static ServiceMethodDescriptor service_methods_[] = {
eval_frame_params },
{ "getAllocationProfile", GetAllocationProfile,
get_allocation_profile_params },
- { "getCallSiteData", GetCallSiteData,
+ { "_getCallSiteData", GetCallSiteData,
get_call_site_data_params },
{ "getClassList", GetClassList,
get_class_list_params },
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/service/service.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698