Tidy up the service protocol. Begin improving the documentation.

runtime/observatory/lib/src/service/object.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of service;
 
 /// A [ServiceObject] represents a persistent object within the vm.
 abstract class ServiceObject extends Observable {
   static int LexicalSortName(ServiceObject o1, ServiceObject o2) {
     return o1.name.compareTo(o2.name);
@@ skipping 292 matching lines @@
       assert(scriptCoverage['script'] != null);
       scriptCoverage['script']._processCallSites(scriptCoverage['callSites']);
     });
   }
 
   Future refreshCallSiteData() {
     Map params = {};
     if (this is! Isolate) {
       params['targetId'] = id;
     }
-    return isolate.invokeRpcNoUpgrade('getCallSiteData', params).then(
+    return isolate.invokeRpcNoUpgrade('_getCallSiteData', params).then(
         (ObservableMap map) {
           var coverage = new ServiceObject._fromMap(isolate, map);
           assert(coverage.type == 'CodeCoverage');
           var coverageList = coverage['coverage'];
           assert(coverageList != null);
           processCallSiteData(coverageList);
           return this;
         });
   }
 }
@@ skipping 241 matching lines @@
     // Note that upgrading the collection creates any isolates in the
     // isolate list which are new.
     _upgradeCollection(map, vm);
 
     _loaded = true;
     version = map['version'];
     targetCPU = map['targetCPU'];
     architectureBits = map['architectureBits'];
     var startTimeMillis = map['startTime'];
     startTime = new DateTime.fromMillisecondsSinceEpoch(startTimeMillis);
-    var refreshTimeMillis = map['refreshTime'];
-    refreshTime = new DateTime.fromMillisecondsSinceEpoch(refreshTimeMillis);
+    refreshTime = new DateTime.now();
     notifyPropertyChange(#upTime, 0, 1);
-    assertsEnabled = map['assertsEnabled'];
     pid = map['pid'];
-    typeChecksEnabled = map['typeChecksEnabled'];
+    assertsEnabled = map['_assertsEnabled'];
+    typeChecksEnabled = map['_typeChecksEnabled'];
     _removeDeadIsolates(map['isolates']);
   }
 
   // Reload all isolates.
   Future reloadIsolates() {
     var reloads = [];
     for (var isolate in isolates) {
       var reload = isolate.reload().catchError((e) {
         Logger.root.info('Bulk reloading of isolates failed: $e');
       });
@@ skipping 1034 matching lines @@
   final Allocations newSpace = new Allocations();
   final Allocations oldSpace = new Allocations();
   final AllocationCount promotedByLastNewGC = new AllocationCount();
 
   bool get hasNoAllocations => newSpace.empty && oldSpace.empty;
 
   @reflectable final fields = new ObservableList<Field>();
   @reflectable final functions = new ObservableList<ServiceFunction>();
 
   @observable Class superclass;
-  @reflectable final interfaces = new ObservableList<Class>();
+  @reflectable final interfaces = new ObservableList<Instance>();
   @reflectable final subclasses = new ObservableList<Class>();
 
   bool get canCache => true;
   bool get immutable => false;
 
   Class._empty(ServiceObjectOwner owner) : super._empty(owner);
 
   void _update(ObservableMap map, bool mapIsRef) {
     name = map['name'];
     vmName = (map.containsKey('vmName') ? map['vmName'] : name);
@@ skipping 26 matching lines @@
     isPatch = map['patch'];
     isImplemented = map['implemented'];
 
     tokenPos = map['tokenPos'];
     endTokenPos = map['endTokenPos'];
 
     subclasses.clear();
     subclasses.addAll(map['subclasses']);
     subclasses.sort(ServiceObject.LexicalSortName);
 
+    interfaces.clear();
+    interfaces.addAll(map['interfaces']);
+    interfaces.sort(ServiceObject.LexicalSortName);
+
     fields.clear();
     fields.addAll(map['fields']);
     fields.sort(ServiceObject.LexicalSortName);
 
     functions.clear();
     functions.addAll(map['functions']);
     functions.sort(ServiceObject.LexicalSortName);
 
     superclass = map['super'];
     // Work-around Object not tracking its subclasses in the VM.
@@ skipping 1238 matching lines @@
     var v = list[i];
     if ((v is ObservableMap) && _isServiceMap(v)) {
       list[i] = owner.getFromMap(v);
     } else if (v is ObservableList) {
       _upgradeObservableList(v, owner);
     } else if (v is ObservableMap) {
       _upgradeObservableMap(v, owner);
     }
   }
 }