Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1053053002: Tidy up the service protocol. Begin improving the documentation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 4603ece0e3d010d5315be9e9c15c4f340122a114..cf9e437ba8dd32acafffaadc102148b67609529d 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -310,7 +310,7 @@ abstract class Coverage {
if (this is! Isolate) {
params['targetId'] = id;
}
- return isolate.invokeRpcNoUpgrade('getCallSiteData', params).then(
+ return isolate.invokeRpcNoUpgrade('_getCallSiteData', params).then(
(ObservableMap map) {
var coverage = new ServiceObject._fromMap(isolate, map);
assert(coverage.type == 'CodeCoverage');
@@ -572,12 +572,11 @@ abstract class VM extends ServiceObjectOwner {
architectureBits = map['architectureBits'];
var startTimeMillis = map['startTime'];
startTime = new DateTime.fromMillisecondsSinceEpoch(startTimeMillis);
- var refreshTimeMillis = map['refreshTime'];
- refreshTime = new DateTime.fromMillisecondsSinceEpoch(refreshTimeMillis);
+ refreshTime = new DateTime.now();
notifyPropertyChange(#upTime, 0, 1);
- assertsEnabled = map['assertsEnabled'];
pid = map['pid'];
- typeChecksEnabled = map['typeChecksEnabled'];
+ assertsEnabled = map['_assertsEnabled'];
+ typeChecksEnabled = map['_typeChecksEnabled'];
_removeDeadIsolates(map['isolates']);
}
@@ -1632,7 +1631,7 @@ class Class extends ServiceObject with Coverage {
@reflectable final functions = new ObservableList<ServiceFunction>();
@observable Class superclass;
- @reflectable final interfaces = new ObservableList<Class>();
+ @reflectable final interfaces = new ObservableList<Instance>();
@reflectable final subclasses = new ObservableList<Class>();
bool get canCache => true;
@@ -1679,6 +1678,10 @@ class Class extends ServiceObject with Coverage {
subclasses.addAll(map['subclasses']);
subclasses.sort(ServiceObject.LexicalSortName);
+ interfaces.clear();
+ interfaces.addAll(map['interfaces']);
+ interfaces.sort(ServiceObject.LexicalSortName);
+
fields.clear();
fields.addAll(map['fields']);
fields.sort(ServiceObject.LexicalSortName);
« no previous file with comments | « runtime/observatory/lib/src/elements/class_view.html ('k') | runtime/observatory/test/call_site_data_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698