Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1012993002: Rename ContributionPoint and error result (Closed)

Created:
5 years, 9 months ago by Brian Wilkerson
Modified:
5 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -55 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/model.dart View 2 chunks +8 lines, -8 lines 2 comments Download
M pkg/analyzer/lib/task/dart.dart View 4 chunks +13 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/task/general.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/task/model.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +19 lines, -15 lines 0 comments Download
M pkg/analyzer/test/src/task/model_test.dart View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 9 months ago (2015-03-16 21:45:59 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1012993002/diff/1/pkg/analyzer/lib/src/task/model.dart File pkg/analyzer/lib/src/task/model.dart (right): https://codereview.chromium.org/1012993002/diff/1/pkg/analyzer/lib/src/task/model.dart#newcode54 pkg/analyzer/lib/src/task/model.dart:54: {CompositeResultDescriptor contributesTo}) { Do we want to use ...
5 years, 9 months ago (2015-03-16 21:48:59 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1012993002/diff/1/pkg/analyzer/lib/src/task/model.dart File pkg/analyzer/lib/src/task/model.dart (right): https://codereview.chromium.org/1012993002/diff/1/pkg/analyzer/lib/src/task/model.dart#newcode54 pkg/analyzer/lib/src/task/model.dart:54: {CompositeResultDescriptor contributesTo}) { > Do we want to use ...
5 years, 9 months ago (2015-03-17 14:52:20 UTC) #4
Brian Wilkerson
5 years, 9 months ago (2015-03-17 14:52:56 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 44534 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698