Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: pkg/analyzer/lib/task/dart.dart

Issue 1012993002: Rename ContributionPoint and error result (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/task/dart.dart
diff --git a/pkg/analyzer/lib/task/dart.dart b/pkg/analyzer/lib/task/dart.dart
index c79064e8b702b08be81916a44106ba43c6f8129a..7137631741e77ec8242e4055d9976fae0dd504bf 100644
--- a/pkg/analyzer/lib/task/dart.dart
+++ b/pkg/analyzer/lib/task/dart.dart
@@ -10,7 +10,6 @@ import 'package:analyzer/src/generated/error.dart';
import 'package:analyzer/src/generated/resolver.dart';
import 'package:analyzer/src/generated/scanner.dart';
import 'package:analyzer/src/generated/source.dart';
-import 'package:analyzer/task/general.dart';
import 'package:analyzer/task/model.dart';
/**
@@ -23,6 +22,17 @@ final ResultDescriptor<CompilationUnitElement> COMPILATION_UNIT_ELEMENT =
'COMPILATION_UNIT_ELEMENT', null);
/**
+ * The analysis errors associated with a target.
+ *
+ * The value combines errors represented by multiple other results.
+ */
+// TODO(brianwilkerson) If we want to associate errors with targets smaller than
+// a file, we will need other contribution points to collect them. In which case
+// we might want to rename this and/or document that it applies to files.
+final CompositeResultDescriptor<List<AnalysisError>> DART_ERRORS =
+ new CompositeResultDescriptor<List<AnalysisError>>('DART_ERRORS');
+
+/**
* The sources of the libraries that are exported from a library.
*
* The list will be empty if there are no exported libraries, but will not be
@@ -83,8 +93,7 @@ final ResultDescriptor<bool> IS_LAUNCHABLE =
*/
final ResultDescriptor<List<AnalysisError>> PARSE_ERRORS =
new ResultDescriptor<List<AnalysisError>>(
- 'PARSE_ERRORS', AnalysisError.NO_ERRORS,
- contributesTo: ANALYSIS_ERRORS);
+ 'PARSE_ERRORS', AnalysisError.NO_ERRORS, contributesTo: DART_ERRORS);
/**
* The compilation unit AST produced while parsing a compilation unit.
@@ -113,7 +122,7 @@ final ResultDescriptor<Namespace> PUBLIC_NAMESPACE =
*/
final ResultDescriptor<List<AnalysisError>> SCAN_ERRORS =
new ResultDescriptor<List<AnalysisError>>(
- 'SCAN_ERRORS', AnalysisError.NO_ERRORS, contributesTo: ANALYSIS_ERRORS);
+ 'SCAN_ERRORS', AnalysisError.NO_ERRORS, contributesTo: DART_ERRORS);
/**
* The token stream produced while scanning a compilation unit.

Powered by Google App Engine
This is Rietveld 408576698