Rename ContributionPoint and error result

pkg/analyzer/lib/src/task/model.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.task.model;
 
 import 'package:analyzer/src/generated/engine.dart' hide AnalysisTask;
 import 'package:analyzer/src/task/inputs.dart';
 import 'package:analyzer/task/model.dart';
 
 /**
- * A concrete implementation of a [ContributionPoint].
+ * A concrete implementation of a [CompositeResultDescriptor].
  */
-class ContributionPointImpl<V> extends ResultDescriptorImpl<V>
-    implements ContributionPoint<V> {
+class CompositeResultDescriptorImpl<V> extends ResultDescriptorImpl<V>
+    implements CompositeResultDescriptor<V> {
   /**
    * The results that contribute to this result.
    */
   final List<ResultDescriptor<V>> contributors = <ResultDescriptor<V>>[];
 
   /**
-   * Initialize a newly created contribution point to have the given [name].
+   * Initialize a newly created composite result to have the given [name].
    */
-  ContributionPointImpl(String name) : super(name, null);
+  CompositeResultDescriptorImpl(String name) : super(name, null);
 
   /**
    * Record that the given analysis [result] contibutes to this result.
    */
   void recordContributor(ResultDescriptor<V> result) {
     contributors.add(result);
   }
 }
 
 /**
  * A concrete implementation of a [ResultDescriptor].
  */
 class ResultDescriptorImpl<V> implements ResultDescriptor<V> {
   /**
    * The name of the result, used for debugging.
    */
   final String name;
 
   /**
    * Return the default value for results described by this descriptor.
    */
   final V defaultValue;
 
   /**
    * Initialize a newly created analysis result to have the given [name] and
-   * [defaultValue]. If a contribution point is specified, then this result will
+   * [defaultValue]. If a composite result is specified, then this result will
    * contribute to it.
    */
   ResultDescriptorImpl(this.name, this.defaultValue,
-      {ContributionPoint contributesTo}) {
-    if (contributesTo is ContributionPointImpl) {
+      {CompositeResultDescriptor contributesTo}) {

[scheglov, 2015/03/16 21:48:59]

Do we want to use a different name?

[Brian Wilkerson, 2015/03/17 14:52:20]

I thought about it, but I think that the individual results contribute to the
composite, so this reads well.

+    if (contributesTo is CompositeResultDescriptorImpl) {
       contributesTo.recordContributor(this);
     }
   }
 
   @override
   TaskInput<V> inputFor(AnalysisTarget target) =>
       new SimpleTaskInput<V>(target, this);
 
   @override
   String toString() => name;
@@ skipping 38 matching lines @@
   AnalysisTask createTask(AnalysisContext context, AnalysisTarget target,
       Map<String, dynamic> inputs) {
     AnalysisTask task = buildTask(context, target);
     task.inputs = inputs;
     return task;
   }
 
   @override
   String toString() => name;
 }