Rename ContributionPoint and error result

pkg/analyzer/lib/task/dart.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.task.dart;
 
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/resolver.dart';
 import 'package:analyzer/src/generated/scanner.dart';
 import 'package:analyzer/src/generated/source.dart';
-import 'package:analyzer/task/general.dart';
 import 'package:analyzer/task/model.dart';
 
 /**
  * The element model associated with a single compilation unit.
  *
  * The result is only available for targets representing a Dart compilation unit.
  */
 final ResultDescriptor<CompilationUnitElement> COMPILATION_UNIT_ELEMENT =
     new ResultDescriptor<CompilationUnitElement>(
         'COMPILATION_UNIT_ELEMENT', null);
 
 /**
+ * The analysis errors associated with a target.
+ *
+ * The value combines errors represented by multiple other results.
+ */
+// TODO(brianwilkerson) If we want to associate errors with targets smaller than
+// a file, we will need other contribution points to collect them. In which case
+// we might want to rename this and/or document that it applies to files.
+final CompositeResultDescriptor<List<AnalysisError>> DART_ERRORS =
+    new CompositeResultDescriptor<List<AnalysisError>>('DART_ERRORS');
+
+/**
  * The sources of the libraries that are exported from a library.
  *
  * The list will be empty if there are no exported libraries, but will not be
  * `null`.
  *
  * The result is only available for targets representing a Dart library.
  */
 final ResultDescriptor<List<Source>> EXPORTED_LIBRARIES =
     new ResultDescriptor<List<Source>>(
         'EXPORTED_LIBRARIES', Source.EMPTY_ARRAY);
@@ skipping 40 matching lines @@
 
 /**
  * The errors produced while parsing a compilation unit.
  *
  * The list will be empty if there were no errors, but will not be `null`.
  *
  * The result is only available for targets representing a Dart compilation unit.
  */
 final ResultDescriptor<List<AnalysisError>> PARSE_ERRORS =
     new ResultDescriptor<List<AnalysisError>>(
-        'PARSE_ERRORS', AnalysisError.NO_ERRORS,
-        contributesTo: ANALYSIS_ERRORS);
+        'PARSE_ERRORS', AnalysisError.NO_ERRORS, contributesTo: DART_ERRORS);
 
 /**
  * The compilation unit AST produced while parsing a compilation unit.
  *
  * The AST structure will not have resolution information associated with it.
  *
  * The result is only available for targets representing a Dart compilation unit.
  */
 final ResultDescriptor<CompilationUnit> PARSED_UNIT =
     new ResultDescriptor<CompilationUnit>('PARSED_UNIT', null);
 
 /**
  * The public [Namespace] of a library.
  *
  * The result is only available for targets representing a Dart library.
  */
 final ResultDescriptor<Namespace> PUBLIC_NAMESPACE =
     new ResultDescriptor<Namespace>('PUBLIC_NAMESPACE', null);
 
 /**
  * The errors produced while scanning a compilation unit.
  *
  * The list will be empty if there were no errors, but will not be `null`.
  *
  * The result is only available for targets representing a Dart compilation unit.
  */
 final ResultDescriptor<List<AnalysisError>> SCAN_ERRORS =
     new ResultDescriptor<List<AnalysisError>>(
-        'SCAN_ERRORS', AnalysisError.NO_ERRORS, contributesTo: ANALYSIS_ERRORS);
+        'SCAN_ERRORS', AnalysisError.NO_ERRORS, contributesTo: DART_ERRORS);
 
 /**
  * The token stream produced while scanning a compilation unit.
  *
  * The value is the first token in the file, or the special end-of-file marker
  * at the end of the stream if the file does not contain any tokens.
  *
  * The result is only available for targets representing a Dart compilation unit.
  */
 final ResultDescriptor<Token> TOKEN_STREAM =
     new ResultDescriptor<Token>('TOKEN_STREAM', null);