Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 9703024: Replacing GLSurface::SetVisibility with SetBufferAllocation for more explicit management. (Closed)

Created:
8 years, 9 months ago by mmocny
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, dhollowa+watch_chromium.org
Visibility:
Public.

Description

Replacing GLSurface::SetVisibility with SetBufferAllocation for more explicit management. This is just a renaming, it still uses the same renderer visibility hooks to decide how to manage buffers. BUG=116049 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -55 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M content/common/gpu/image_transport_surface_linux.cc View 8 chunks +24 lines, -22 lines 0 comments Download
M content/common/gpu/image_transport_surface_win.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M ui/gfx/gl/gl_surface.h View 2 chunks +8 lines, -8 lines 0 comments Download
M ui/gfx/gl/gl_surface.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mmocny
8 years, 9 months ago (2012-03-14 15:25:50 UTC) #1
piman
lgtm
8 years, 9 months ago (2012-03-14 16:51:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmocny@chromium.org/9703024/1
8 years, 9 months ago (2012-03-14 17:00:53 UTC) #3
commit-bot: I haz the power
Presubmit check for 9703024-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-14 17:00:58 UTC) #4
mmocny
Al, since backer@ is out for the week, may you take a look at gfx/ui/gl/ ...
8 years, 9 months ago (2012-03-14 17:02:21 UTC) #5
apatrick_chromium
ui/gfx/gl LGTM
8 years, 9 months ago (2012-03-14 18:01:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmocny@chromium.org/9703024/1
8 years, 9 months ago (2012-03-14 18:01:33 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 21:14:13 UTC) #8
Change committed as 126731

Powered by Google App Engine
This is Rietveld 408576698