Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: ui/gfx/gl/gl_surface.h

Issue 9703024: Replacing GLSurface::SetVisibility with SetBufferAllocation for more explicit management. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/texture_image_transport_surface.cc ('k') | ui/gfx/gl/gl_surface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/gl/gl_surface.h
diff --git a/ui/gfx/gl/gl_surface.h b/ui/gfx/gl/gl_surface.h
index c5c62cb6575cd6c835e4bdf3c211b9292779d988..0c61ea8921afc4ba8fc29f02fb0c39ebc1045c96 100644
--- a/ui/gfx/gl/gl_surface.h
+++ b/ui/gfx/gl/gl_surface.h
@@ -71,14 +71,14 @@ class GL_EXPORT GLSurface : public base::RefCounted<GLSurface> {
// on error.
virtual bool OnMakeCurrent(GLContext* context);
- // This gives a hint as to whether this surface is visible. If it is not
- // visible, the backing store need not be preserved.
- enum VisibilityState {
- VISIBILITY_STATE_FOREGROUND,
- VISIBILITY_STATE_BACKGROUND,
- VISIBILITY_STATE_HIBERNATED
+ // Used for explicit buffer management. Expect buffers to be destroyed only
+ // when surface is not visible.
+ enum BufferAllocationState {
+ BUFFER_ALLOCATION_FRONT_AND_BACK,
+ BUFFER_ALLOCATION_FRONT_ONLY,
+ BUFFER_ALLOCATION_NONE
};
- virtual void SetVisibility(VisibilityState visibility_state);
+ virtual void SetBufferAllocation(BufferAllocationState state);
// Get a handle used to share the surface with another process. Returns null
// if this is not possible.
@@ -135,7 +135,7 @@ class GL_EXPORT GLSurfaceAdapter : public GLSurface {
virtual void* GetHandle() OVERRIDE;
virtual unsigned int GetBackingFrameBufferObject() OVERRIDE;
virtual bool OnMakeCurrent(GLContext* context) OVERRIDE;
- virtual void SetVisibility(VisibilityState visibility_state) OVERRIDE;
+ virtual void SetBufferAllocation(BufferAllocationState state) OVERRIDE;
virtual void* GetShareHandle() OVERRIDE;
virtual void* GetDisplay() OVERRIDE;
virtual void* GetConfig() OVERRIDE;
« no previous file with comments | « content/common/gpu/texture_image_transport_surface.cc ('k') | ui/gfx/gl/gl_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698