Issue 9692039: Add a message that the list of directories needing owners may not be accurate on first upload, beca…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9692039: Add a message that the list of directories needing owners may not be accurate on first upload, beca… (Closed)

Created:
8 years, 9 months ago by Pam (message me for reviews)

Modified:
8 years, 9 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

DO NOT SUBMIT Change the number of whitespace-ending lines shown from 5 to 20.

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
	M	presubmit_canned_checks.py	View		1 chunk	+5 lines, -5 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View		1 chunk	+16 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Pam (message me for reviews)

Pending confirmation from John that he's only seeing the directories he owns on the first ...

8 years, 9 months ago (2012-03-13 10:18:07 UTC) #1

Dirk Pranke

lgtm for now as a workaround / improvement. I think we need to solve this ...

8 years, 9 months ago (2012-03-13 21:41:19 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pam@chromium.org/9692039/1

8 years, 9 months ago (2012-03-15 12:51:31 UTC) #3

Change committed as 126894