Add a message that the list of directories needing owners may not be accurate on first upload, beca…

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 
 ### Description checks
 
 def CheckChangeHasTestField(input_api, output_api):
@@ skipping 734 matching lines @@
   affected_files = set([f.LocalPath() for f in
       input_api.change.AffectedFiles(file_filter=source_file_filter)])
 
   owners_db = input_api.owners_db
   owner_email, reviewers = _RietveldOwnerAndReviewers(
       input_api,
       owners_db.email_regexp,
       approval_needed=input_api.is_committing)
 
   if owner_email:
+    message = ''
     reviewers_plus_owner = reviewers.union(set([owner_email]))
-  elif input_api.is_committing:
-    return [output_api.PresubmitWarning(
-        'The issue was not uploaded so you have no OWNER approval.')]
   else:
+    message = ('\nUntil the issue is uploaded, this list will include '
+               'directories for which you \nare an OWNER.')
     owner_email = ''
     reviewers_plus_owner = set()
 
   missing_directories = owners_db.directories_not_covered_by(affected_files,
       reviewers_plus_owner)
   if missing_directories:
-    return [output('Missing %s for files in these directories:\n    %s' %
-                   (needed, '\n    '.join(missing_directories)))]
+    return [output('Missing %s for files in these directories:\n    %s%s' %
+                   (needed, '\n    '.join(missing_directories), message))]
 
   if input_api.is_committing and not reviewers:
     return [output('Missing LGTM from someone other than %s' % owner_email)]
   return []
 
 
 def _RietveldOwnerAndReviewers(input_api, email_regexp, approval_needed=False):
   """Return the owner and reviewers of a change, if any.
 
   If approval_needed is True, only reviewers who have approved the change
@@ skipping 159 matching lines @@
     results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
         input_api, output_api))
     snapshot("checking license")
     results.extend(input_api.canned_checks.CheckLicense(
         input_api, output_api, license_header, source_file_filter=sources))
     snapshot("checking was uploaded")
     results.extend(input_api.canned_checks.CheckChangeWasUploaded(
         input_api, output_api))
   snapshot("done")
   return results