Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: presubmit_canned_checks.py

Issue 9692039: Add a message that the list of directories needing owners may not be accurate on first upload, beca… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
===================================================================
--- presubmit_canned_checks.py (revision 125828)
+++ presubmit_canned_checks.py (working copy)
@@ -752,19 +752,19 @@
approval_needed=input_api.is_committing)
if owner_email:
+ message = ''
reviewers_plus_owner = reviewers.union(set([owner_email]))
- elif input_api.is_committing:
- return [output_api.PresubmitWarning(
- 'The issue was not uploaded so you have no OWNER approval.')]
else:
+ message = ('\nUntil the issue is uploaded, this list will include '
+ 'directories for which you \nare an OWNER.')
owner_email = ''
reviewers_plus_owner = set()
missing_directories = owners_db.directories_not_covered_by(affected_files,
reviewers_plus_owner)
if missing_directories:
- return [output('Missing %s for files in these directories:\n %s' %
- (needed, '\n '.join(missing_directories)))]
+ return [output('Missing %s for files in these directories:\n %s%s' %
+ (needed, '\n '.join(missing_directories), message))]
if input_api.is_committing and not reviewers:
return [output('Missing LGTM from someone other than %s' % owner_email)]
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698