Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: tests/presubmit_unittest.py

Issue 9692039: Add a message that the list of directories needing owners may not be accurate on first upload, beca… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
===================================================================
--- tests/presubmit_unittest.py (revision 125828)
+++ tests/presubmit_unittest.py (working copy)
@@ -2231,14 +2231,28 @@
rietveld_response=response,
expected_output='')
- def testCannedCheckOwners_NoIssue(self):
+ def testCannedCheckOwners_NoIssueNoFiles(self):
self.AssertOwnersWorks(issue=None,
expected_output="OWNERS check failed: this change has no Rietveld "
"issue number, so we can't check it for approvals.\n")
-
self.AssertOwnersWorks(issue=None, is_committing=False,
expected_output="")
+ def testCannedCheckOwners_NoIssue(self):
+ self.AssertOwnersWorks(issue=None,
+ uncovered_dirs=set(['foo']),
+ expected_output="OWNERS check failed: this change has no Rietveld "
+ "issue number, so we can't check it for approvals.\n")
+ self.AssertOwnersWorks(issue=None,
+ is_committing=False,
+ uncovered_dirs=set(['foo']),
+ expected_output='Missing OWNER reviewers for files in these '
+ 'directories:\n'
+ ' foo\n'
+ 'Until the issue is uploaded, this list will include '
+ 'directories for which you \n'
+ 'are an OWNER.\n')
+
def testCannedCheckOwners_NoLGTM(self):
self.AssertOwnersWorks(expected_output='Missing LGTM from someone '
'other than john@example.com\n')
« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698