Separate out the platform-independent parts of Channel reading.

Separate out the platform-independent parts of Channel reading.

I'm planning on comsolidating the platform-independent management of the
overflow buffer and message dispatch between the posix and windows channels.
This patch separates out the behavior into the functions I'm planning on adding
on the virtual interface.

Basically, ProcessIncomingMessages and DispatchInputData will be the main
shared code. In future patches, I'll refactor Windows in a similar way and then
combine them into a shared base class.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124489

[brettw, 2012-03-01 06:43:23]

Now with EasyReview™ comments.

https://chromiumcodereview.appspot.com/9570001/diff/3003/ipc/ipc_channel_posi...
File ipc/ipc_channel_posix.cc (left):

https://chromiumcodereview.appspot.com/9570001/diff/3003/ipc/ipc_channel_posi...
ipc/ipc_channel_posix.cc:483: if (pipe_ == -1)
This check moved to ReadData

https://chromiumcodereview.appspot.com/9570001/diff/3003/ipc/ipc_channel_posi...
ipc/ipc_channel_posix.cc:494: while (p < end) {
This block moved to DispatchInputData.

https://chromiumcodereview.appspot.com/9570001/diff/3003/ipc/ipc_channel_posi...
ipc/ipc_channel_posix.cc:499: if (!PopulateMessageFileDescriptors(&m))
This was renamed to WillDispatchInputMessage (since it will be a virtual
function on the base class that the posix implementation will use to fill in any
remaining handles).

https://chromiumcodereview.appspot.com/9570001/diff/3003/ipc/ipc_channel_posi...
ipc/ipc_channel_posix.cc:519: if (input_overflow_buf_.empty() &&
!input_fds_.empty()) {
This check moved to DidEmptyInputBuffers.

https://chromiumcodereview.appspot.com/9570001/diff/3003/ipc/ipc_channel_posi...
ipc/ipc_channel_posix.cc:993: // Possibly combine with the overflow buffer to
make a larger buffer.
This moved to DispatchInputData.

[Elliot Glaysher, 2012-03-01 19:24:31]

lgtm

[commit-bot: I haz the power, 2012-03-01 19:59:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/brettw@chromium.org/9570001/3003

[commit-bot: I haz the power, 2012-03-01 21:41:49]

Change committed as 124489