Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 9566022: Rename NaCl/pepper gamepad interface from _dev to stable (Closed)

Created:
8 years, 9 months ago by scottmg
Modified:
8 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Rename NaCl/pepper gamepad interface from _dev to stable Following API review, and revisions here: https://chromiumcodereview.appspot.com/9405033/. This change is just the mechanical renames and bump of version number to 1.0. BUG=112879, 115119 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125399

Patch Set 1 #

Patch Set 2 : missed renames #

Patch Set 3 : fix .srpc and run_srpcgen.py #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -293 lines) Patch
M native_client_sdk/src/examples/gamepad/gamepad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/examples/gamepad/gamepad.cc View 4 chunks +5 lines, -5 lines 0 comments Download
D ppapi/api/dev/ppb_gamepad_dev.idl View 1 chunk +0 lines, -95 lines 0 comments Download
A + ppapi/api/ppb_gamepad.idl View 3 chunks +9 lines, -9 lines 0 comments Download
D ppapi/c/dev/ppb_gamepad_dev.h View 1 chunk +0 lines, -112 lines 0 comments Download
A + ppapi/c/ppb_gamepad.h View 5 chunks +16 lines, -16 lines 0 comments Download
M ppapi/examples/gamepad/gamepad.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_globals.h View 3 chunks +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_gamepad_rpc_server.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_gamepad.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_gamepad.cc View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_gamepad.srpc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_server.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppb_rpc.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppb_rpc.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_sources.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/all_c_includes.h View 2 chunks +1 line, -1 line 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/thunk/interfaces_ppb_public_stable.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/ppb_gamepad_thunk.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/event_conversion.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/event_conversion.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scottmg
brettw for ppapi/, and noelallen@ for native_client_sdk/ and ppapi/native_client/
8 years, 9 months ago (2012-03-01 20:13:29 UTC) #1
noelallen1
You are missing the SRPC changes in src/ppapi/native_client/src/shared/ppapi_proxy/ppb_gamepad.srpc Didn't the function name change? At the ...
8 years, 9 months ago (2012-03-01 20:34:10 UTC) #2
scottmg
On 2012/03/01 20:34:10, noelallen1 wrote: > You are missing the SRPC changes in > src/ppapi/native_client/src/shared/ppapi_proxy/ppb_gamepad.srpc ...
8 years, 9 months ago (2012-03-01 21:44:57 UTC) #3
brettw
When do you need to land this by? I want to see if we can ...
8 years, 9 months ago (2012-03-05 18:27:25 UTC) #4
scottmg
For 19 branch. On Mar 5, 2012 10:27 AM, <brettw@chromium.org> wrote: > When do you ...
8 years, 9 months ago (2012-03-05 18:36:56 UTC) #5
scottmg
On 2012/03/05 18:36:56, scottmg wrote: > For 19 branch. Metabug tracking/targeting 19 here: http://code.google.com/p/chromium/issues/detail?id=115119
8 years, 9 months ago (2012-03-06 19:21:36 UTC) #6
brettw
Okay, I've been convinced not to worry about arrays for this patch right now. Let's ...
8 years, 9 months ago (2012-03-07 05:59:37 UTC) #7
scottmg
On 2012/03/07 05:59:37, brettw wrote: > Okay, I've been convinced not to worry about arrays ...
8 years, 9 months ago (2012-03-07 06:10:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/9566022/13001
8 years, 9 months ago (2012-03-07 15:17:20 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-07 16:53:18 UTC) #10
Change committed as 125399

Powered by Google App Engine
This is Rietveld 408576698