Close and delete pnacl temp files when compile or link fails.

Close and delete pnacl temp files when compile or link fails.
Move bitcode download earlier, so that temp files are not created
(and will not need to be cleaned) if the bitcode download fails.

We will probably need to convert everything to WeakRefAnchors
to clean up these up more consistently in the dtors.

R=sehr@google.com
BUG= none
TEST= run_pnacl_bad_browser_test (currently need to manually check
the user filesystem to see it's clean after running).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124393

[jvoung - send to chromium..., 2012-02-29 23:18:49]

This should handle cleanup for normal compile/link failures.

If you'd like to wait on a CL that refactors things to use weakref anchors, let
me know.

http://codereview.chromium.org/9561004/diff/1/ppapi/native_client/src/trusted...
File ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc (left):

http://codereview.chromium.org/9561004/diff/1/ppapi/native_client/src/trusted...
ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc:451: int32_t
file_desc_ok_to_close = DUP(file_desc);
removed this part because it looked like GetLoadedFileDesc() already does a DUP.

[jvoung - send to chromium..., 2012-02-29 23:47:36]

On 2012/02/29 23:18:49, jvoung wrote:
> This should handle cleanup for normal compile/link failures.
> 
> If you'd like to wait on a CL that refactors things to use weakref anchors,
let
> me know.
> 
>
http://codereview.chromium.org/9561004/diff/1/ppapi/native_client/src/trusted...
> File ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc (left):
> 
>
http://codereview.chromium.org/9561004/diff/1/ppapi/native_client/src/trusted...
> ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc:451: int32_t
> file_desc_ok_to_close = DUP(file_desc);
> removed this part because it looked like GetLoadedFileDesc() already does a
DUP.

It seems like WeakRefAnchors helps limit the scenarios to these two

1) callback is invoked, and argument to callback is guaranteed to still be
allocated.

or

2) callback is not invoked, and argument is deleted for you.


That doesn't really allow us to keep the pnacl_coordinator and plugin alive
until all scratch files are deleted (requires a sequence of callbacks).

It could help with avoiding use-after-free bugs though.

To really clean up the temp files, we may need to rely on the browser to
occasionally clean up files that we were unable to clean up in the allotted
surf-away time-window.

[sehr (please use chromium), 2012-03-01 04:02:38]

lgtm

[commit-bot: I haz the power, 2012-03-01 06:41:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jvoung@google.com/9561004/3001

[commit-bot: I haz the power, 2012-03-01 09:46:20]

Change committed as 124393