Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: ppapi/native_client/src/trusted/plugin/json_manifest.cc

Issue 9561004: Close and delete pnacl temp files when compile or link fails. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments, remove printf Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/trusted/plugin/json_manifest.cc
diff --git a/ppapi/native_client/src/trusted/plugin/json_manifest.cc b/ppapi/native_client/src/trusted/plugin/json_manifest.cc
index 81d956d7ec5c4b65b2b786bdfe6e16ec137fa4c6..49d18b9ba09154c4bc85e5dc65a0534e0dc905f8 100644
--- a/ppapi/native_client/src/trusted/plugin/json_manifest.cc
+++ b/ppapi/native_client/src/trusted/plugin/json_manifest.cc
@@ -119,7 +119,7 @@ bool IsValidDictionary(const Json::Value& dictionary,
valid_keys,
valid_key_count)) {
// TODO(jvoung): Should this set error_string and return false?
- PLUGIN_PRINTF(("WARNING: '%s' property '%s' has unknown key '%s'.",
+ PLUGIN_PRINTF(("WARNING: '%s' property '%s' has unknown key '%s'.\n",
parent_key.c_str(),
container_key.c_str(), property_name.c_str()));
}
@@ -236,10 +236,10 @@ bool IsValidISADictionary(const Json::Value& dictionary,
// it could be "arch/portable" : { "pnacl-translate": URLSpec }
// for executables that need to be translated.
Json::Value property_value = dictionary[property_name];
- if (!IsValidPnaclTranslateSpec(property_value, property_name,
- parent_key, error_string) &&
- !IsValidUrlSpec(property_value, property_name, parent_key,
- error_string)) {
+ if (!IsValidUrlSpec(property_value, property_name, parent_key,
+ error_string) &&
+ !IsValidPnaclTranslateSpec(property_value, property_name,
+ parent_key, error_string)) {
return false;
}
}
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698