Close and delete pnacl temp files when compile or link fails.

ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_
 #define NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_
 
 #include <set>
 #include <map>
 #include <vector>
@@ skipping 243 matching lines @@
   void ResourcesDidLoad(int32_t pp_error);
 
   // Callbacks for temporary file related stages.
   // They are invoked from ResourcesDidLoad and proceed in declaration order.
   // Invoked when the temporary file system is successfully opened in PPAPI.
   void FileSystemDidOpen(int32_t pp_error);
   // Invoked after we are sure the PNaCl temporary directory exists.
   void DirectoryWasCreated(int32_t pp_error);
   // Invoked after we have checked the PNaCl cache for a translated version.
   void CachedFileDidOpen(int32_t pp_error);
+  // Invoked after we have started pulling down the bitcode file.
+  void BitcodeFileDidOpen(int32_t pp_error);
   // Invoked when the write descriptor for obj_file_ is created.
   void ObjectWriteDidOpen(int32_t pp_error);
   // Invoked when the read descriptor for obj_file_ is created.
   void ObjectReadDidOpen(int32_t pp_error);
-  // Invoked when the read descriptor for nexe_file_ is created.
-  void NexeWriteDidOpen(int32_t pp_error);
   // Invoked when the descriptors for obj_file_ have been closed.
   void ObjectFileWasClosed(int32_t pp_error);
   // Invoked when the obj_file_ temporary has been deleted.
   void ObjectFileWasDeleted(int32_t pp_error);
   // Invoked when the descriptors for nexe_file_ have been closed.
   void NexeFileWasClosed(int32_t pp_error);
   // Invoked when the nexe_file_ temporary has been renamed to the nexe name.
   void NexeFileWasRenamed(int32_t pp_error);
   // Invoked when the read descriptor for nexe_file_ is created.
   void NexeReadDidOpen(int32_t pp_error);
+  // Invoked if there was an error and we've cleaned up the nexe_file_ temp.
+  void NexeFileWasDeleted(int32_t pp_error);
 
   // Once llc and ld nexes have been loaded and the two temporary files have
   // been created, this starts the translation.  Translation starts two
   // subprocesses, one for llc and one for ld.
   void RunTranslate(int32_t pp_error);
   // Starts an individual llc or ld subprocess used for translation.
   NaClSubprocess* StartSubprocess(const nacl::string& url,
                                   const Manifest* manifest);
   // PnaclCoordinator creates a helper thread to allow translations to be
   // invoked via SRPC.  This is the helper thread function for translation.
   static void WINAPI DoTranslateThread(void* arg);
   // Returns true if a the translate thread and subprocesses should stop.
   bool SubprocessesShouldDie();
   // Signal the translate thread and subprocesses that they should stop.
   void SetSubprocessesShouldDie(bool subprocesses_should_die);
   // Signal that Pnacl translation completed normally.
   void TranslateFinished(int32_t pp_error);
+  // Keeps track of the pp_error upon entry to TranslateFinished,
+  // for inspection after cleanup.
+  int32_t translate_finish_error_;
+
   // Signal that Pnacl translation failed, from the translation thread only.
   void TranslateFailed(const nacl::string& error_string);
 
   // The plugin owning the nexe for which we are doing translation.
   Plugin* plugin_;
 
   pp::CompletionCallback translate_notify_callback_;
   // PnaclRefCount is only needed to support file lookups.
   // TODO(sehr): remove this when file lookup is through ReverseService.
   pp::CompletionCallbackFactory<PnaclCoordinator,
@@ skipping 32 matching lines @@
   // The URL for the pexe file.
   nacl::string pexe_url_;
   // Optional cache identity for translation caching.
   nacl::string cache_identity_;
   // Borrowed reference which must outlive the thread.
   nacl::scoped_ptr<nacl::DescWrapper> pexe_wrapper_;
   // Object file, produced by the translator and consumed by the linker.
   nacl::scoped_ptr<LocalTempFile> obj_file_;
   // Translated nexe file, produced by the linker and consumed by sel_ldr.
   nacl::scoped_ptr<LocalTempFile> nexe_file_;
-  // Callbacks to run when tasks or completed or an error has occurred.
+  // Callback to run when tasks are completed or an error has occurred.
   pp::CompletionCallback report_translate_finished_;
 
   // Used to report information when errors (PPAPI or otherwise) are reported.
   ErrorInfo error_info_;
   // True if an error was already reported, and translate_notify_callback_
   // was already run/consumed.
   bool error_already_reported_;
 };
 
 //----------------------------------------------------------------------
 
 }  // namespace plugin;
 #endif  // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_